You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/03/28 08:55:16 UTC
[jira] [Commented] (CB-6344) Specify after which sibling to add
config-changes in plugin.xml
[ https://issues.apache.org/jira/browse/CB-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950468#comment-13950468 ]
ASF GitHub Bot commented on CB-6344:
------------------------------------
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/68
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form (`munge.files[file].parents[parent][index] { xml, count, after }`)
* add an after parameter to graftXML which contains a list of possible predecessor elements separated by semicolon
* fix unit tests and add new ones
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-plugman config-file-after-option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugman/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 0616f1fefd24cad93715f16b6cabb94d3356e0cb
Author: Martin Bektchiev <ma...@telerik.com>
Date: 2014-03-26T08:15:39Z
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form (munge.files[file].parents[parent][index] { xml, count, after })
* add an after parameter to graftXML which contains a list of possible predecessor elements separated by semicolon
* fix unit tests and add new ones
----
> Specify after which sibling to add config-changes in plugin.xml
> ---------------------------------------------------------------
>
> Key: CB-6344
> URL: https://issues.apache.org/jira/browse/CB-6344
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugman
> Reporter: Martin Bektchiev
> Assignee: Martin Bektchiev
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The order of XML elements is important In the Windows Phone manifest file. (e.g. see http://msdn.microsoft.com/en-us/library/windowsphone/develop/ff769509%28v=vs.105%29.aspx#BKMK_EXTENSIONSelement). That's why we need to provide a way to specify where a specific element has to be added.
--
This message was sent by Atlassian JIRA
(v6.2#6252)