You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2002/01/21 21:29:12 UTC
cvs commit: apache-1.3/src/include http_protocol.h
wrowe 02/01/21 12:29:12
Modified: src/include http_protocol.h
Log:
ap_rprintf is implemented as API_EXPORT() in http_protocol.c.
Therefore, make the prototype and implementation consistant.
The question remains, why no compiler warning/emit? Because MSVC [my
version, at least] must have changed all of the ap_fn(foo, ...) decl
from _stdcall to _cdecl, on it's own!
I suggest our declarations are still borked, but they have worked only
because MSVC ignored our poor judgement :)
Revision Changes Path
1.55 +1 -1 apache-1.3/src/include/http_protocol.h
Index: http_protocol.h
===================================================================
RCS file: /home/cvs/apache-1.3/src/include/http_protocol.h,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -r1.54 -r1.55
--- http_protocol.h 28 Dec 2001 05:03:06 -0000 1.54
+++ http_protocol.h 21 Jan 2002 20:29:12 -0000 1.55
@@ -150,7 +150,7 @@
API_EXPORT(int) ap_rwrite(const void *buf, int nbyte, request_rec *r);
API_EXPORT_NONSTD(int) ap_rvputs(request_rec *r,...);
API_EXPORT(int) ap_vrprintf(request_rec *r, const char *fmt, va_list vlist);
-API_EXPORT_NONSTD(int) ap_rprintf(request_rec *r, const char *fmt,...)
+API_EXPORT(int) ap_rprintf(request_rec *r, const char *fmt,...)
__attribute__((format(printf,2,3)));
API_EXPORT(int) ap_rflush(request_rec *r);
Re: cvs commit: apache-1.3/src/include http_protocol.h
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
> wrowe 02/01/21 12:29:12
>
> Modified: src/include http_protocol.h
> Log:
> ap_rprintf is implemented as API_EXPORT() in http_protocol.c.
> Therefore, make the prototype and implementation consistant.
>
> The question remains, why no compiler warning/emit? Because MSVC [my
> version, at least] must have changed all of the ap_fn(foo, ...) decl
> from _stdcall to _cdecl, on it's own!
>
> I suggest our declarations are still borked, but they have worked only
> because MSVC ignored our poor judgement :)
I just proved this theory to myself by reapplying the .c patches without
reapplying the .h patches to make these fns _NONSTD. No warning. Changing
the return type for one of the ap_rprintf() declarations caused a prototype
mismatch warning - so we know the http_protocol.c really is reading the .h
prototypes.
I could commit the correct fixes or leave them alone. I don't care at this
point.
Bill
Re: cvs commit: apache-1.3/src/include http_protocol.h
Posted by "William A. Rowe, Jr." <wr...@covalent.net>.
> wrowe 02/01/21 12:29:12
>
> Modified: src/include http_protocol.h
> Log:
> ap_rprintf is implemented as API_EXPORT() in http_protocol.c.
> Therefore, make the prototype and implementation consistant.
>
> The question remains, why no compiler warning/emit? Because MSVC [my
> version, at least] must have changed all of the ap_fn(foo, ...) decl
> from _stdcall to _cdecl, on it's own!
>
> I suggest our declarations are still borked, but they have worked only
> because MSVC ignored our poor judgement :)
I just proved this theory to myself by reapplying the .c patches without
reapplying the .h patches to make these fns _NONSTD. No warning. Changing
the return type for one of the ap_rprintf() declarations caused a prototype
mismatch warning - so we know the http_protocol.c really is reading the .h
prototypes.
I could commit the correct fixes or leave them alone. I don't care at this
point.
Bill