Change in asterixdb[master]: ASTERIXDB-1566: Fixed External Hash Group By to conform to t...

["Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>]

Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1566: Fixed External Hash Group By to conform to the memory budget
......................................................................


Patch Set 23:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1056/23/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTableTest.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTableTest.java:

Line 82:     }
I ran SqlppExecutionTest and ExecutionTest with this patch, but didn't see that executeGarbageCollection() was executed in either of the runtime test.

Add unit test for executeGarbageCollection and isGarbageCollectionNeeded here.

You probably can use MockIto (http://site.mockito.org/) to simplify unit tests.  NullMissingTest is an example that uses MockIto.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5
Gerrit-PatchSet: 23
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <ji...@gmail.com>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Wenhai Li <lw...@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes