You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by rathijit <gi...@git.apache.org> on 2016/08/13 04:57:09 UTC

[GitHub] incubator-quickstep issue #90: Quickstep 28 29

Github user rathijit commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/90
  
    Summary of review comments with @hbdeshmukh  on 08/12/2016.
    
    ## TODO
    * Fix cyclic dependencies
    * Pass bool to SpinMutex constructor instead of byte pointer
    * Add comment in code to discuss removal of align restrictions in hash table payload construction
    * Overall, add/update comments for doxygen
    
    ## DISCUSSIONS
    * Is a lock needed for the hash table payload? Probably yes.
    
    ## POTENTIAL FUTURE WORK
    * Combine aggregation handling in finalize
    * Stop calling finalize for non-avg aggregates


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---