You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by po...@apache.org on 2026/05/03 15:23:56 UTC

(airflow) branch v3-2-test updated: [v3-2-test] Skip test_schedule_tis_start_trigger pending #55068 backport decision (#66309)

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch v3-2-test
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/v3-2-test by this push:
     new ee5e52739a0 [v3-2-test] Skip test_schedule_tis_start_trigger pending #55068 backport decision (#66309)
ee5e52739a0 is described below

commit ee5e52739a02f337e627ca4357ce943238e79bc0
Author: Jarek Potiuk <ja...@potiuk.com>
AuthorDate: Sun May 3 17:23:49 2026 +0200

    [v3-2-test] Skip test_schedule_tis_start_trigger pending #55068 backport decision (#66309)
    
    The `start_from_trigger` deferred-at-schedule path is commented out
    on v3-2-test (disabled in 91e10295c7d as a TODO) and was only
    re-enabled on main by #55068, which landed one day after the v3-2
    branch was cut. The test asserts the feature works and fails on
    v3-2-test CI.
    
    Skip the test on the 3.2 line and link the tracking issue from both
    the test skip-reason and the disabled production-code site so the
    follow-up isn't lost. Decision (backport #55068 or formally drop
    the feature on 3.2) is tracked in #66307.
---
 airflow-core/src/airflow/models/dagrun.py     | 2 ++
 airflow-core/tests/unit/models/test_dagrun.py | 5 +++++
 2 files changed, 7 insertions(+)

diff --git a/airflow-core/src/airflow/models/dagrun.py b/airflow-core/src/airflow/models/dagrun.py
index 20ec118f33e..7eabadd73cf 100644
--- a/airflow-core/src/airflow/models/dagrun.py
+++ b/airflow-core/src/airflow/models/dagrun.py
@@ -2005,6 +2005,8 @@ class DagRun(Base, LoggingMixin):
             # to render start_from_trigger in the scheduler. If we need to
             # render the value in a worker, it kind of defeats the purpose of
             # this feature (which is to save a worker process if possible).
+            # Re-enabled on main by #55068 but not backported to 3.2;
+            # decision tracked at https://github.com/apache/airflow/issues/66307
             # elif task.start_trigger_args is not None:
             #     if task.expand_start_from_trigger(context=ti.get_template_context()):
             #         ti.start_date = timezone.utcnow()
diff --git a/airflow-core/tests/unit/models/test_dagrun.py b/airflow-core/tests/unit/models/test_dagrun.py
index 6aa4fc84c76..93bf2dcbdf4 100644
--- a/airflow-core/tests/unit/models/test_dagrun.py
+++ b/airflow-core/tests/unit/models/test_dagrun.py
@@ -2260,6 +2260,11 @@ def test_schedule_tis_only_one_scheduler_update_succeeds_when_competing(dag_make
     assert refreshed_ti.try_number == 1
 
 
+@pytest.mark.skip(
+    reason="start_from_trigger scheduling path is disabled on v3-2-test "
+    "(re-enabled on main by #55068, not backported); "
+    "tracked at https://github.com/apache/airflow/issues/66307"
+)
 @pytest.mark.need_serialized_dag
 def test_schedule_tis_start_trigger(dag_maker, session):
     """