You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/14 17:55:10 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #789:
Add RISC-V FPU support
xiaoxiang781216 opened a new pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408345720
##########
File path: arch/risc-v/src/common/up_initialize.c
##########
@@ -113,6 +116,13 @@ void up_initialize(void)
up_addregion();
+ /* Initialize the idle task stack info */
+
+ idle = this_task(); /* It should be idle task */
+ idle->stack_alloc_ptr = _END_BSS;
+ idle->adj_stack_ptr = (FAR void *)g_idle_topstack;
+ idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE;
+
Review comment:
TizenRT implemented this by forcing all architectures to following the same pattern: https://github.com/Samsung/TizenRT/blob/master/os/kernel/init/os_start.c#L369
But they do not support very man architectures. For NuttX, most but not all architectures follow this pattern as described in the TODO list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408336124
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
Review comment:
I wonder if this should not be fixed by amending the FPU commit. Otherwise, the history will be misleading. It will appear that the file came in as a Pinecone file, then was changed to Apache. That would be inappropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408339539
##########
File path: arch/risc-v/src/common/up_initialize.c
##########
@@ -113,6 +116,13 @@ void up_initialize(void)
up_addregion();
+ /* Initialize the idle task stack info */
+
+ idle = this_task(); /* It should be idle task */
+ idle->stack_alloc_ptr = _END_BSS;
+ idle->adj_stack_ptr = (FAR void *)g_idle_topstack;
+ idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE;
+
Review comment:
For most architectures, the adj_stack_size might not be CONFIG_IDLETHREAD_STACKSIZE. it might be smaller to alignment requirements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #789: Add RISC-V
FPU support
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408381758
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
+
+/************************************************************************************
+ * Included Files
+ ************************************************************************************/
+
+#include <nuttx/config.h>
+#include <arch/rv32im/irq.h>
+
+#ifdef CONFIG_ARCH_FPU
+
+/************************************************************************************
+ * Pre-processor Definitions
+ ************************************************************************************/
+
+/************************************************************************************
+ * Public Symbols
+ ************************************************************************************/
+
+ .globl up_fpuconfig
+ .globl up_savefpu
+ .globl up_restorefpu
+
+ .file "up_fpu.S"
+
+#define FS_MASK 0x6000
+#define FS_OFF 0x0000
+#define FS_INITIAL 0x2000
+#define FS_CLEAN 0x4000
+#define FS_DIRTY 0x6000
+
+#if defined(CONFIG_ARCH_DPFPU)
+# define FLOAD fld
+# define FSTORE fsd
+#elif defined(CONFIG_ARCH_QPFPU)
+# define FLOAD flq
+# define FSTORE fsq
+#else
+# define FLOAD flw
+# define FSTORE fsw
+#endif
Review comment:
It also uses TABs in the #defines, but since there are no coding standards for .S files I suppose that is not problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408376404
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
+
+/************************************************************************************
+ * Included Files
+ ************************************************************************************/
+
+#include <nuttx/config.h>
+#include <arch/rv32im/irq.h>
+
+#ifdef CONFIG_ARCH_FPU
+
+/************************************************************************************
+ * Pre-processor Definitions
+ ************************************************************************************/
+
+/************************************************************************************
+ * Public Symbols
+ ************************************************************************************/
+
+ .globl up_fpuconfig
+ .globl up_savefpu
+ .globl up_restorefpu
+
+ .file "up_fpu.S"
+
+#define FS_MASK 0x6000
+#define FS_OFF 0x0000
+#define FS_INITIAL 0x2000
+#define FS_CLEAN 0x4000
+#define FS_DIRTY 0x6000
+
+#if defined(CONFIG_ARCH_DPFPU)
+# define FLOAD fld
+# define FSTORE fsd
+#elif defined(CONFIG_ARCH_QPFPU)
+# define FLOAD flq
+# define FSTORE fsq
+#else
+# define FLOAD flw
+# define FSTORE fsw
+#endif
Review comment:
I have already merged this, but I just noted that these #defines are in the wrong place. They should be moved up inot the "Pre-processor Definitions" section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408330439
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
Review comment:
Okay... nevermind. I see this is fixed in the following commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408331748
##########
File path: arch/risc-v/src/common/up_initialize.c
##########
@@ -113,6 +116,13 @@ void up_initialize(void)
up_addregion();
+ /* Initialize the idle task stack info */
+
+ idle = this_task(); /* It should be idle task */
+ idle->stack_alloc_ptr = _END_BSS;
+ idle->adj_stack_ptr = (FAR void *)g_idle_topstack;
+ idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE;
+
Review comment:
It would be nice to generalize this for all architectures. There is description in top-level TODO list of how this might be done in nx_start().
Putting this logic in each up_initialize() is probably fine too since we really cannot handle faults until up_initailize() is called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408345720
##########
File path: arch/risc-v/src/common/up_initialize.c
##########
@@ -113,6 +116,13 @@ void up_initialize(void)
up_addregion();
+ /* Initialize the idle task stack info */
+
+ idle = this_task(); /* It should be idle task */
+ idle->stack_alloc_ptr = _END_BSS;
+ idle->adj_stack_ptr = (FAR void *)g_idle_topstack;
+ idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE;
+
Review comment:
TizenRT implemented this by forcing all architectures to following the same pattern: https://github.com/Samsung/TizenRT/blob/master/os/kernel/init/os_start.c#L369
But they do not support very many architectures. For NuttX, most but not all architectures follow this pattern as described in the TODO list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408329699
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
Review comment:
All new files coming into the repository MUST have an Apache 2.0 license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408333733
##########
File path: arch/risc-v/src/common/up_initialize.c
##########
@@ -113,6 +116,13 @@ void up_initialize(void)
up_addregion();
+ /* Initialize the idle task stack info */
+
+ idle = this_task(); /* It should be idle task */
+ idle->stack_alloc_ptr = _END_BSS;
+ idle->adj_stack_ptr = (FAR void *)g_idle_topstack;
+ idle->adj_stack_size = CONFIG_IDLETHREAD_STACKSIZE;
+
Review comment:
Sure, I will provide a patch to apply the similar change to other arch tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request
#789: Add RISC-V FPU support
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #789: Add RISC-V FPU support
URL: https://github.com/apache/incubator-nuttx/pull/789#discussion_r408336124
##########
File path: arch/risc-v/src/rv32im/up_fpu.S
##########
@@ -0,0 +1,251 @@
+/************************************************************************************
+ * arch/risc-v/src/rv32im/up_fpu.S
+ *
+ * Copyright (C) 2018 Pinecone Inc. All rights reserved.
+ * Author: Zhang Xiaoqin <zh...@pinecone.net>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in
+ * the documentation and/or other materials provided with the
+ * distribution.
+ * 3. Neither the name NuttX nor the names of its contributors may be
+ * used to endorse or promote products derived from this software
+ * without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+ * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+ * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+ * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS
+ * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED
+ * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ * POSSIBILITY OF SUCH DAMAGE.
+ *
+ ************************************************************************************/
Review comment:
I wonder if this should not be fixed by amending the FPU commit. Otherwise, the history will be misleading. It will appear that the file came in as a Pinecone file, then was changed to Apache. That would be inappropriate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services