You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2016/08/03 12:53:29 UTC
[4/7] mesos git commit: Libprocess: Renamed actor IDs for consistency.
Libprocess: Renamed actor IDs for consistency.
Enforce the following actor ID schema in libprocess:
- Actor IDs contain only lowercase characters, dashes or underscores.
- The ID of an actor that is exposed to libprocess users, via a route/
associated to an endpoint uses dashes as word separator, e.g., `help`.
- The ID of an actor internal to libprocess, with not associated
route/endpoint, must be enclosed in double quotes and use underscores
instead of dashes as word separator, e.g.,
`__authentication_router__`.
Review: https://reviews.apache.org/r/50519/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/a755c24f
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/a755c24f
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/a755c24f
Branch: refs/heads/master
Commit: a755c24f80752c9a27b761852a5a561072d53fae
Parents: 145a73c
Author: Gast�n Kleiman <ga...@mesosphere.com>
Authored: Wed Aug 3 14:25:34 2016 +0200
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Wed Aug 3 14:28:07 2016 +0200
----------------------------------------------------------------------
3rdparty/libprocess/src/authenticator_manager.cpp | 2 +-
3rdparty/libprocess/src/reap.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/a755c24f/3rdparty/libprocess/src/authenticator_manager.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/authenticator_manager.cpp b/3rdparty/libprocess/src/authenticator_manager.cpp
index 7def832..a22acd0 100644
--- a/3rdparty/libprocess/src/authenticator_manager.cpp
+++ b/3rdparty/libprocess/src/authenticator_manager.cpp
@@ -55,7 +55,7 @@ private:
AuthenticatorManagerProcess::AuthenticatorManagerProcess()
- : ProcessBase(ID::generate("AuthenticationRouter")) {}
+ : ProcessBase(ID::generate("__authentication_router__")) {}
Future<Nothing> AuthenticatorManagerProcess::setAuthenticator(
http://git-wip-us.apache.org/repos/asf/mesos/blob/a755c24f/3rdparty/libprocess/src/reap.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/reap.cpp b/3rdparty/libprocess/src/reap.cpp
index ac60c6d..f8d2fdc 100644
--- a/3rdparty/libprocess/src/reap.cpp
+++ b/3rdparty/libprocess/src/reap.cpp
@@ -64,7 +64,7 @@ Duration MAX_REAP_INTERVAL() { return Seconds(1); }
class ReaperProcess : public Process<ReaperProcess>
{
public:
- ReaperProcess() : ProcessBase(ID::generate("reaper")) {}
+ ReaperProcess() : ProcessBase(ID::generate("__reaper__")) {}
Future<Option<int> > reap(pid_t pid)
{