You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/05/30 00:04:42 UTC
Review Request 22049: Make unknown container not a Failure for
Isolator::destroy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22049/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1438
https://issues.apache.org/jira/browse/MESOS-1438
Repository: mesos-git
Description
-------
Make unknown container not a Failure for Isolator::destroy.
Diffs
-----
src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
Diff: https://reviews.apache.org/r/22049/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 22049: Make unknown container not a Failure for
Isolator::destroy.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22049/#review44332
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22049]
All tests passed.
- Mesos ReviewBot
On May 29, 2014, 10:04 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22049/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 10:04 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1438
> https://issues.apache.org/jira/browse/MESOS-1438
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Make unknown container not a Failure for Isolator::destroy.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
> src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
>
> Diff: https://reviews.apache.org/r/22049/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 22049: Make unknown container not a Failure for
Isolator::destroy.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22049/#review44304
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/22049/#comment78657>
Can you add a comment on why this is ok?
src/slave/containerizer/isolators/cgroups/mem.cpp
<https://reviews.apache.org/r/22049/#comment78658>
ditto.
- Vinod Kone
On May 29, 2014, 10:04 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22049/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 10:04 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1438
> https://issues.apache.org/jira/browse/MESOS-1438
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Make unknown container not a Failure for Isolator::destroy.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/cgroups/cpushare.cpp b494a9236210245383e20fa9ab3dbac01e42f8dd
> src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd288975872c26685c713910d778def4e10
>
> Diff: https://reviews.apache.org/r/22049/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>