[GitHub] [phoenix] twdsilva commented on a change in pull request #544: PHOENIX-5104: breaks client backwards compatibility

[GitBox <gi...@apache.org>]

twdsilva commented on a change in pull request #544: PHOENIX-5104: breaks client backwards compatibility
URL: https://github.com/apache/phoenix/pull/544#discussion_r303546597
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
 ##########
 @@ -1507,6 +1508,16 @@ public MutationState close(CloseStatement statement) throws SQLException {
         return new MutationState(0, 0, connection);
     }
 
+    /**
+     * Supprort long viewIndexId only if client has explicitly set
+     * the QueryServices.LONG_VIEW_INDEX_ENABLED_ATTRIB connection property to 'true'.
+     * @return
+     */
+    private PDataType getViewIndexDataType() throws SQLException {
+        boolean supportsLongViewIndexId = "true".equalsIgnoreCase(connection.getClientInfo(LONG_VIEW_INDEX_ENABLED_ATTRIB));
 
 Review comment:
   Can you please add a default value for ```LONG_VIEW_INDEX_ENABLED_ATTRIB``` to ```QueryServicesOptions``` and set it to false and look it up similar to :
   
   ```
   boolean asyncIndexBuildEnabled = connection.getQueryServices().getProps().getBoolean(
                   QueryServices.INDEX_ASYNC_BUILD_ENABLED,
                   QueryServicesOptions.DEFAULT_INDEX_ASYNC_BUILD_ENABLED);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services