You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/03 14:25:44 UTC

[GitHub] [kafka] dengziming commented on pull request #10793: KAFKA-12338: Remove useless MetadataParser

dengziming commented on pull request #10793:
URL: https://github.com/apache/kafka/pull/10793#issuecomment-853911013


   @hachikuji Thanks for the remindings, I think the validations in `read` are useful and I copied them to `MetadataRecordSerde`, but not sure whether the `DEFAULT_FRAME_VERSION_SIZE` check can be applied to `MetadataRecordSerde`, because the logic in `MetadataParser` is size=apiKey+apiVersion+message while in `MetadataRecordSerde` is size=**frameVersion**+apiKey+apiVersion+message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org