You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2017/11/25 15:32:56 UTC
[GitHub] nifi-minifi-cpp pull request #206: MINIFICPP-320: Change Processors to be wi...
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/206
MINIFICPP-320: Change Processors to be within their own linked object
This will facilitate the eventual move and documentation that follows
enabling a processor module.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-320
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #206
----
commit c02aa041dee7ba8df53dfe1278bc33db988c49ba
Author: Marc Parisi <ph...@apache.org>
Date: 2017-11-05T15:52:35Z
MINIFICPP-320: Change Processors to be within their own linked object
This will facilitate the eventual move and documentation that follows
enabling a processor module.
----
---
[GitHub] nifi-minifi-cpp issue #206: MINIFICPP-320: Change Processors to be within th...
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/206
@calebj There was a commit to resolve it on my rhel7 platform. This was merged before that could be added ( once I saw Travis ) -- I put that commit within https://github.com/apache/nifi-minifi-cpp/pull/207
---
[GitHub] nifi-minifi-cpp pull request #206: MINIFICPP-320: Change Processors to be wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/206
---
[GitHub] nifi-minifi-cpp issue #206: MINIFICPP-320: Change Processors to be within th...
Posted by calebj <gi...@git.apache.org>.
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/206
This causes some tests to fail to link on Linux both on Travis CI and cloud9, both of which are Ubuntu Trusty. Here's the output:
```
[ 19%] Linking CXX executable TestExecuteProcess
libminifi/libminifi.a(ListenHTTP.cpp.o): In function `org::apache::nifi::minifi::processors::ListenHTTP::WriteCallback::process(std::shared_ptr<org::apache::nifi::minifi::io::BaseStream>)':
ListenHTTP.cpp:(.text+0x9e): undefined reference to `mg_read'
ListenHTTP.cpp:(.text+0x10e): undefined reference to `mg_read'
libminifi/libminifi.a(ListenHTTP.cpp.o): In function `org::apache::nifi::minifi::processors::ListenHTTP::Handler::handlePost(CivetServer*, mg_connection*)':
ListenHTTP.cpp:(.text+0xd80): undefined reference to `mg_get_request_info'
ListenHTTP.cpp:(.text+0xe50): undefined reference to `mg_printf'
ListenHTTP.cpp:(.text+0x133d): undefined reference to `mg_printf'
ListenHTTP.cpp:(.text+0x14c8): undefined reference to `mg_printf'
ListenHTTP.cpp:(.text+0x1508): undefined reference to `mg_printf'
ListenHTTP.cpp:(.text+0x15a4): undefined reference to `mg_printf'
libminifi/libminifi.a(ListenHTTP.cpp.o):ListenHTTP.cpp:(.text+0x16a6): more undefined references to `mg_printf' follow
libminifi/libminifi.a(ListenHTTP.cpp.o): In function `org::apache::nifi::minifi::processors::ListenHTTP::onSchedule(org::apache::nifi::minifi::core::ProcessContext*, org::apache::nifi::minifi::core::ProcessSessionFactory*)':
ListenHTTP.cpp:(.text+0x254a): undefined reference to `CivetServer::CivetServer(std::vector<std::string, std::allocator<std::string> >, CivetCallbacks const*)'
ListenHTTP.cpp:(.text+0x25cb): undefined reference to `CivetServer::addHandler(std::string const&, CivetHandler*)'
libminifi/libminifi.a(ListenHTTP.cpp.o): In function `org::apache::nifi::minifi::processors::ListenHTTP::Handler::sendErrorResponse(mg_connection*)':
ListenHTTP.cpp:(.text+0x76b): undefined reference to `mg_printf'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTIN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTIN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x10): undefined reference to `typeinfo for CivetHandler'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x20): undefined reference to `CivetHandler::handleGet(CivetServer*, mg_connection*)'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x30): undefined reference to `CivetHandler::handleHead(CivetServer*, mg_connection*)'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x38): undefined reference to `CivetHandler::handlePut(CivetServer*, mg_connection*)'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x40): undefined reference to `CivetHandler::handleDelete(CivetServer*, mg_connection*)'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x48): undefined reference to `CivetHandler::handleOptions(CivetServer*, mg_connection*)'
libminifi/libminifi.a(ListenHTTP.cpp.o):(.rodata._ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE[_ZTVN3org6apache4nifi6minifi10processors10ListenHTTP7HandlerE]+0x50): undefined reference to `CivetHandler::handlePatch(CivetServer*, mg_connection*)'
collect2: error: ld returned 1 exit status
make[2]: *** [TestExecuteProcess] Error 1
make[1]: *** [CMakeFiles/TestExecuteProcess.dir/all] Error 2
make: *** [all] Error 2
```
---