You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/19 15:54:33 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4847: Restricting http access on VR to internal network

weizhouapache commented on a change in pull request #4847:
URL: https://github.com/apache/cloudstack/pull/4847#discussion_r597791035



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsApp.py
##########
@@ -61,12 +61,12 @@ def setup(self):
 
         self.fw.append([
             "", "front",
-            "-A INPUT -i %s -d %s/32 -p tcp -m tcp -m state --state NEW --dport 80 -j ACCEPT" % (self.dev, self.ip)
+            "-A INPUT -i %s -s %s/32 -p tcp -m tcp -m state --state NEW --dport 80 -j ACCEPT" % (self.dev, self.ip)

Review comment:
       @Spaceman1984 should the source be the guest network ?
   
   refer to https://github.com/apache/cloudstack/pull/3907/files




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org