You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/08 08:42:06 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
LuciferYang opened a new pull request, #37435:
URL: https://github.com/apache/spark/pull/37435
### What changes were proposed in this pull request?
This pr just remove redundant `LevelDB.get(key)` in `RemoteBlockPushResolver`.
### Why are the changes needed?
This is no need to check `db.get(key) != null` before `db.delete(key)`. LevelDB will handle this scene.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm closed pull request #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
Posted by GitBox <gi...@apache.org>.
mridulm closed pull request #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
URL: https://github.com/apache/spark/pull/37435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #37435:
URL: https://github.com/apache/spark/pull/37435#issuecomment-1208527026
Merged to master.
Thanks for the PR @LuciferYang !
Thanks for the review @srowen :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37435:
URL: https://github.com/apache/spark/pull/37435#issuecomment-1208854105
thanks @srowen @mridulm ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37435: [SPARK-40004][CORE] Remove redundant `LevelDB.get` in `RemoteBlockPushResolver`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37435:
URL: https://github.com/apache/spark/pull/37435#issuecomment-1207840913
This minor change should not be coupled with the refactoring work of SPARK-38909, I think this change may worth doing even if SPARK-38909 is not accepted in the end, .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org