You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2018/11/12 02:16:41 UTC
[GitHub] chenhao7253886 commented on a change in pull request #299: Fix
failed cases in regression test
chenhao7253886 commented on a change in pull request #299: Fix failed cases in regression test
URL: https://github.com/apache/incubator-doris/pull/299#discussion_r232520292
##########
File path: fe/src/main/java/org/apache/doris/rewrite/FoldConstantsRule.java
##########
@@ -58,14 +64,14 @@
public class FoldConstantsRule implements ExprRewriteRule {
public static ExprRewriteRule INSTANCE = new FoldConstantsRule();
- private Multimap<String, FEFunctionInvoker> functions = ArrayListMultimap.create();
+ private ImmutableMultimap<String, FEFunctionInvoker> functions;
+ private ImmutableSet<String> nonNullResultWithNullParamFunctions;
Review comment:
ok, i will add some comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org