[jira] [Commented] (NIFI-3614) HandleHttpResponse doesn't properly handle "not number" status codes

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928719#comment-15928719 ] 

ASF GitHub Bot commented on NIFI-3614:
--------------------------------------

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/1598

    NIFI-3614 Adding "return" statement to HandleHttpResponse when status…

    …Code is not a number
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [X] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-3614

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1598
    
----
commit 8c4a5a649000b17adc386299a7712cd04940a84f
Author: Joe Percivall <jp...@apache.org>
Date:   2017-03-16T18:11:46Z

    NIFI-3614 Adding "return" statement to HandleHttpResponse when statusCode is not a number

----


> HandleHttpResponse doesn't properly handle "not number" status codes
> --------------------------------------------------------------------
>
>                 Key: NIFI-3614
>                 URL: https://issues.apache.org/jira/browse/NIFI-3614
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 0.7.1, 1.1.1
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
>            Priority: Minor
>
> HandleHttpResponse has a check for "isNumber" for the statusCode but the resulting block doesn't have a return statement[1] so it just continues to attempt to execute and hits a "not most up to date version of flowfile" exception.
> [1] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java#L138



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)