You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/11/09 13:36:05 UTC

[GitHub] [hbase] LALAYANG commented on pull request #3615: HBASE-26217 Clean shared state pollution to avoid flaky tests.

LALAYANG commented on pull request #3615:
URL: https://github.com/apache/hbase/pull/3615#issuecomment-964157972


   In test `org.apache.hadoop.hbase.monitoring.TestTaskMonitor.testDoNotPurgeRPCTask`, `TaskMonitor` is not created each time, so the pollution is not cleaned. 
   
   There are 2 kinds of fixes:
   - Clean all tasks when the test ends.
   - Another solution is to create a new TaskMonitor each time to avoid pollution similar to the other tests (e.g., testTaskMonitorBasics, testTasksGetAbortedOnLeak) in TestTaskMonitor. Create a new TaskMonitor each time to avoid flaky tests. LALAYANG/hbase#1
   Please let me know which fix you think is better. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org