[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10371: [Documentation] Document the configuration of Project JDK and Maven JDK in IntelliJ

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #10371:
URL: https://github.com/apache/pulsar/pull/10371#discussion_r621748149



##########
File path: site2/website/contributing.md
##########
@@ -118,43 +118,10 @@ these two remotes for pushing changes).
 
 You are now ready to start developing!
 
-#### [Optional] IDE Setup
+#### IDE Setup
 
-Depending on your preferred development environment, you may need to prepare it to develop Pulsar code.
+Please find the [instructions for IDE Setup in the README.md](https://github.com/apache/pulsar/#setting-up-your-ide) file. 

Review comment:
       ```suggestion
   For how to set up IDE, see [here](https://github.com/apache/pulsar/blob/master/README.md#setting-up-your-ide). 
   ```

##########
File path: README.md
##########
@@ -136,6 +136,27 @@ required plugins.
 
 ### Intellij
 
+#### Configure Project JDK to Java 8 (1.8) JDK
+
+1. Open Project Settings dialog by going to  
+   `File -> Project Structure -> Project Settings -> Project`.
+   
+2. Click on the JDK version drop down and select `Download JDK...` or choose an existing recent Java 8 (1.8) JDK version.

Review comment:
       ```suggestion
   2. Select the JDK version.
       
       From the JDK version drop-down list, select **Download JDK...** or choose an existing recent Java 8 (1.8) JDK version.
   ```

##########
File path: README.md
##########
@@ -136,6 +136,27 @@ required plugins.
 
 ### Intellij
 
+#### Configure Project JDK to Java 8 (1.8) JDK
+
+1. Open Project Settings dialog by going to  
+   `File -> Project Structure -> Project Settings -> Project`.

Review comment:
       ```suggestion
   1. Open **Project Settings**. 
   
       Click **File** -> **Project Structure** -> **Project Settings** -> **Project**.
   ```

##########
File path: README.md
##########
@@ -136,6 +136,27 @@ required plugins.
 
 ### Intellij
 
+#### Configure Project JDK to Java 8 (1.8) JDK
+
+1. Open Project Settings dialog by going to  
+   `File -> Project Structure -> Project Settings -> Project`.

Review comment:
       In technical writing, normally, we use "bold" for buttons instead of "code style" (``).
   Please check all occurencies. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org