You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/18 18:35:19 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
KacerCZ opened a new pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772
https://issues.apache.org/jira/browse/NETBEANS-5367
First step to be able to implement annotations in module not listed in friend packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812036464
IMHO, one should be *really* sure that the API is good (usable and stable, at least) before making it public. Also, it seems to me quite unexpected to make the first public PHP API from this module exactly... But I won't be blocking this PR, of course; however, I will not approve it either.
@jtulach
It would be definitely good to know what Jarda thinks about this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812060836
I know that everyone says friend modules are evil, but I see only two options:
- accept that fact or
- be willing to break API
I think both options should be considered (yes, there are reasons API should be broken) - in this case we are late in the cycle, so why not add a friend and plan for publication of the API in the next cycle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mvorisek commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
mvorisek commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-836306197
Hi @KacerCZ, did you make the module and is basic generics like `array<ClassName>` supported by the latest Netbeans at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ closed pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
KacerCZ closed pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-836494583
@mvorisek Support for PHPStan annotations is in progress and is separate from array format.
Relevant issue is https://issues.apache.org/jira/browse/NETBEANS-4983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-811836721
Is there any objection to this, @junichi11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-811838682
@tmysik Is this OK?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812057027
My goal is to implement PHPStan annotations in "php.code.analysis" module (because this module implements PHPStan support).
PHP Annotations API can be made public (as I understand it is prefered for Java APIs) or "php.code.analysis" module will need to become friend.
I'd like to know what NetBeans veterans think is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812062330
Definitely a friend, IMHO. Exactly the same as for all the other PHP modules. Making any API public really needs to be planned and reviewed properly, it is a big commitment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812062765
They're not evil, just should never have been used to mark unstable APIs IMO. (JDK has right approach on opt-in).
However, agree with adding a friend on a one release basis. Push this to 12.5 for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812062765
They're not evil, just should never have been used to mark unstable APIs IMO. (JDK has right approach on opt-in).
However, agree with adding a friend on a one release basis given where we're at. Push this to 12.5 for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2772: [NETBEANS-5367] Changed PHP Annotation API to public
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2772:
URL: https://github.com/apache/netbeans/pull/2772#issuecomment-812071884
OK, I'll make it friend module.
Thanks for your time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists