You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/08/11 17:06:16 UTC
[PR] fix(mock): reject missing ACL rule deletions [rocketmq-dashboard]
yyqdbngt opened a new pull request, #1940:
URL: https://github.com/apache/rocketmq-dashboard/pull/1940
## Summary
- make mock ACL rule deletion reject unknown IDs instead of silently succeeding
- align mock-mode failure behavior with persisted API semantics
- verify a failed deletion leaves the mock store unchanged
## Validation
- `NODE_OPTIONS=--no-experimental-webstorage npx vitest run src/services/aclService.test.ts`
- targeted ESLint and repository formatting hooks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mock): reject missing ACL rule deletions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #1940: fix(mock): reject missing ACL rule deletions
URL: https://github.com/apache/rocketmq-dashboard/pull/1940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mock): reject missing ACL rule deletions [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #1940:
URL: https://github.com/apache/rocketmq-dashboard/pull/1940#issuecomment-5278766564
Closing after maintainer review: these mock-store tweaks (collision-safe IDs / strict deletions) only affect the development Mock mode and bring limited value relative to review and maintenance cost, so we are not taking them. Thanks for the effort — please focus future contributions on user-facing features and fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org