You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/08 19:23:06 UTC
[GitHub] [beam] y1chi opened a new pull request #13702: [BEAM-11474] Set log entry transform id using step name with best effort
y1chi opened a new pull request #13702:
URL: https://github.com/apache/beam/pull/13702
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on a change in pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on a change in pull request #13702:
URL: https://github.com/apache/beam/pull/13702#discussion_r554269624
##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java
##########
@@ -44,6 +44,9 @@
private static final Map<Thread, ExecutionStateTracker> CURRENT_TRACKERS =
new ConcurrentHashMap<>();
+ private static final Map<Long, ExecutionStateTracker> CURRENT_TRACKERS_FOR_THREAD_ID =
Review comment:
The `CURRENT_TRACKERS_FOR_THREAD_ID` seems like the same mapping as the `CURRENT_TRACKERS`. Any reason that we cannot refer to `CURRENT_TRACKERS`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #13702:
URL: https://github.com/apache/beam/pull/13702#issuecomment-756990633
This PR address the same issue for the reverted change https://github.com/apache/beam/pull/13696, and should have very little performance complication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #13702:
URL: https://github.com/apache/beam/pull/13702#issuecomment-758318934
Run Java_Examples_Dataflow PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz commented on pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
boyuanzz commented on pull request #13702:
URL: https://github.com/apache/beam/pull/13702#issuecomment-758318890
Run Java_Examples_Dataflow_Java11 PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a change in pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #13702:
URL: https://github.com/apache/beam/pull/13702#discussion_r555270486
##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java
##########
@@ -44,6 +44,9 @@
private static final Map<Thread, ExecutionStateTracker> CURRENT_TRACKERS =
new ConcurrentHashMap<>();
+ private static final Map<Long, ExecutionStateTracker> CURRENT_TRACKERS_FOR_THREAD_ID =
Review comment:
The main reason is that CURRENT_TRACKERS map is keyed by Thread reference and in a log entry we only record the thread id, which means we need to enumerate through CURRENT_TRACKER entry set or the current thread group when we want to find the ExecutionStateTracker with the thread id, which seems more costly then just hold another map for thread id -> ExecutionStateTracker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #13702:
URL: https://github.com/apache/beam/pull/13702#issuecomment-757012237
R: @boyuanzz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a change in pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #13702:
URL: https://github.com/apache/beam/pull/13702#discussion_r555381212
##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java
##########
@@ -44,6 +44,9 @@
private static final Map<Thread, ExecutionStateTracker> CURRENT_TRACKERS =
new ConcurrentHashMap<>();
+ private static final Map<Long, ExecutionStateTracker> CURRENT_TRACKERS_FOR_THREAD_ID =
Review comment:
Looks like there's no particular reason the CURRENT_TRACKER cannot be keyed by thread id so I've combined the two.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on a change in pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on a change in pull request #13702:
URL: https://github.com/apache/beam/pull/13702#discussion_r555270486
##########
File path: runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/ExecutionStateTracker.java
##########
@@ -44,6 +44,9 @@
private static final Map<Thread, ExecutionStateTracker> CURRENT_TRACKERS =
new ConcurrentHashMap<>();
+ private static final Map<Long, ExecutionStateTracker> CURRENT_TRACKERS_FOR_THREAD_ID =
Review comment:
The main reason is that CURRENT_TRACKERS map is keyed by Thread reference and in a log entry we only record the thread id, which means we need to enumerate through CURRENT_TRACKER entry set or the current thread group when we want to find the ExecutionStateTracker with the thread id, which seems more costly than just hold another map for thread id -> ExecutionStateTracker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] y1chi commented on pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
y1chi commented on pull request #13702:
URL: https://github.com/apache/beam/pull/13702#issuecomment-756990633
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] boyuanzz merged pull request #13702: [BEAM-11474] Set log entry transform id with best effort in Java SDK harness
Posted by GitBox <gi...@apache.org>.
boyuanzz merged pull request #13702:
URL: https://github.com/apache/beam/pull/13702
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org