You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/04/26 15:39:28 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #26419: Run unit tests with pre-released dependencies.

damccorm commented on code in PR #26419:
URL: https://github.com/apache/beam/pull/26419#discussion_r1178058852


##########
sdks/python/tox.ini:
##########
@@ -62,23 +62,32 @@ commands_post =
   bash {toxinidir}/scripts/run_tox_cleanup.sh
 commands = false {envname} is misconfigured
 
+# Run the tests using pre-released dependencies.
+# https://github.com/apache/beam/issues/25668
 [testenv:py{37,38,39,310,311}]
+pip_pre = True

Review Comment:
   Can we just define this once in the shared config? https://github.com/apache/beam/blob/f1d92d47cb34ed9190030c875fdcf5b84f62e253/sdks/python/tox.ini#L29
   
   Is there a reason to have it defined in some locations, but not others?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org