You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2020/12/24 10:21:53 UTC

[GitHub] [incubator-pegasus] levy5307 commented on a change in pull request #662: feat(hotkey): add an interface to query hotkey on the specified partition

levy5307 commented on a change in pull request #662:
URL: https://github.com/apache/incubator-pegasus/pull/662#discussion_r548482229



##########
File path: src/server/hotkey_collector.cpp
##########
@@ -168,6 +168,7 @@ inline void hotkey_collector::change_state_by_result()
     case hotkey_collector_state::FINE_DETECTING:
         if (!_result.hot_hash_key.empty()) {
             change_state_to_finished();
+            derror_replica("Find the hotkey: {}", _result.hot_hash_key);

Review comment:
       why did you use derror_replica? what about dwarn_replica?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org