[GitHub] piiswrong commented on a change in pull request #10435: [MXNET-289] Allow specifying number of batches to run in an epoch to fix hang in dist sync for last epoch

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #10435: [MXNET-289] Allow specifying number of batches to run in an epoch to fix hang in dist sync for last epoch
URL: https://github.com/apache/incubator-mxnet/pull/10435#discussion_r180529287
 
 

 ##########
 File path: python/mxnet/module/base_module.py
 ##########
 @@ -399,7 +399,7 @@ def fit(self, train_data, eval_data=None, eval_metric='acc',
             eval_batch_end_callback=None, initializer=Uniform(0.01),
             arg_params=None, aux_params=None, allow_missing=False,
             force_rebind=False, force_init=False, begin_epoch=0, num_epoch=None,
-            validation_metric=None, monitor=None, sparse_row_id_fn=None):
+            validation_metric=None, monitor=None, sparse_row_id_fn=None, epoch_size=None):
 
 Review comment:
   fit already has far too many arguments. Try using resizeiter

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services