[jira] [Commented] (CAMEL-7864) The kafka component does not properly support zookeeper chroot configuration

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148623#comment-14148623 ] 

ASF GitHub Bot commented on CAMEL-7864:
---------------------------------------

GitHub user johnmshields opened a pull request:

    https://github.com/apache/camel/pull/281

    CAMEL-7864: Updates to allow setting Kafka's zookeeper.connect directly.

    - Added new property to KafkaConfiguration for zookeeperConnection and
      configured it to override the zookeeperHost and zookeeperPort
      properties.
    - Created getZookeeperConnect method on KafkaConfiguration to return
      the zookeeperConnect property if set or the combination of host ":"
      port if zookeeperConnect is not set.
    - Added zookeeperConnect get and set methods on KafkaEndpoint to
      delegate to KafkaConfiguration.
    - Updated KafkaConsumer to use the getZookeeperConnect method on the
      KafkaEndpoint.
    - Added tests for the changes.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnmshields/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #281
    
----
commit 64696f05293e55ec42f88ef2fed4e28cc9d52a5a
Author: john.shields <jo...@tubemogul.com>
Date:   2014-09-26T01:57:23Z

    CAMEL-7864: Updates to allow setting Kafka's zookeeper.connect directly.
    
    - Added new property to KafkaConfiguration for zookeeperConnection and
      configured it to override the zookeeperHost and zookeeperPort
      properties.
    - Created getZookeeperConnect method on KafkaConfiguration to return
      the zookeeperConnect property if set or the combination of host ":"
      port if zookeeperConnect is not set.
    - Added zookeeperConnect get and set methods on KafkaEndpoint to
      delegate to KafkaConfiguration.
    - Updated KafkaConsumer to use the getZookeeperConnect method on the
      KafkaEndpoint.
    - Added tests for the changes.

----


> The kafka component does not properly support zookeeper chroot configuration
> ----------------------------------------------------------------------------
>
>                 Key: CAMEL-7864
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7864
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-kafka
>    Affects Versions: 2.13.2
>            Reporter: John Shields
>
> The following code in the KafkaConsumer.java file prevents the use of a chroot connection to zookeeper:
> {noformat}
>         props.put("zookeeper.connect", endpoint.getZookeeperHost() + ":" + endpoint.getZookeeperPort());
> {noformat}
> I propose simply combining the host and port endpoint properties to a simple "zookeeper.connect" property to give the most flexibility to the end user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)