You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "snehashisp (via GitHub)" <gi...@apache.org> on 2024/11/10 16:43:03 UTC
[PR] [WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
snehashisp opened a new pull request, #17742:
URL: https://github.com/apache/kafka/pull/17742
The is one of a set of PRs for [KIP-891](https://cwiki.apache.org/confluence/display/KAFKA/KIP-891%3A+Running+multiple+versions+of+Connector+plugins). The list of total PRs given below all build one the previous one in the list. They can be reviewed individually, or if the complete set of changes is preferrable, please refer to the last PR.
This is PR#3 and contains changes to support multiple versions of transformation and predicates with appropriate defaults and validations.
1. https://github.com/apache/kafka/pull/16984 - Plugins Loading Isolation Changes
2. https://github.com/apache/kafka/pull/17741 - Versioned Configs and Validation for Connector and Converters
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
Posted by "snehashisp (via GitHub)" <gi...@apache.org>.
snehashisp commented on PR #17742:
URL: https://github.com/apache/kafka/pull/17742#issuecomment-2552244828
Updated the code to include the latest suggestion. The failed test looks unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
Posted by "snehashisp (via GitHub)" <gi...@apache.org>.
snehashisp commented on PR #17742:
URL: https://github.com/apache/kafka/pull/17742#issuecomment-2544058666
HI @gharris1727. I have updated the code a bit. PTAL and LMK if you have any queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
Posted by "snehashisp (via GitHub)" <gi...@apache.org>.
snehashisp commented on PR #17742:
URL: https://github.com/apache/kafka/pull/17742#issuecomment-2570044894
Hi @gharris1727, please follow up on this review and the subsequent ones for multiversioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] KIP-891: Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 commented on code in PR #17742:
URL: https://github.com/apache/kafka/pull/17742#discussion_r1887268918
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -594,12 +609,15 @@ void enrich(ConfigDef newDef) {
int orderInGroup = 0;
final String typeConfig = prefix + "type";
+ final String versionConfig = prefix + WorkerConfig.PLUGIN_VERSION_SUFFIX;
+
+ // Add the class configuration
final ConfigDef.Validator typeValidator = ConfigDef.LambdaValidator.with(
(String name, Object value) -> {
validateProps(prefix);
// The value will be null if the class couldn't be found; no point in performing follow-up validation
if (value != null) {
- getConfigDefFromConfigProvidingClass(typeConfig, (Class<?>) value);
+ getConfigDefFromPlugin(typeConfig, ((Class<?>) value).getName(), null, plugins);
Review Comment:
I think this validator needs to include the error when the version is incorrect, similar to the converters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18419: KIP-891 Connect Multiversion Support (Transformation and Predicate Changes) [kafka]
Posted by "gharris1727 (via GitHub)" <gi...@apache.org>.
gharris1727 merged PR #17742:
URL: https://github.com/apache/kafka/pull/17742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org