You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/04 17:48:09 UTC

[GitHub] [spark] MaxGekk opened a new pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

MaxGekk opened a new pull request #28729:
URL: https://github.com/apache/spark/pull/28729


   ### What changes were proposed in this pull request?
   Set `spark.sql.datetime.java8API.enabled` to `true` in:
   1. `SparkSQLEnv.init()` of Thrift server, and
   2. `SparkOperation. withLocalProperties()`
   
   ### Why are the changes needed?
   1. Date and timestamp string literals are parsed by using Java 8 time API and Spark's session time zone. Before the changes, date/timestamp values were collected as legacy types `java.sql.Date`/`java.sql.Timestamp`, and the value of such types didn't respect the config `spark.sql.session.timeZone`. To have consistent view, users had to keep JVM time zone and Spark's session time zone in sync.
   2. After the changes, formatting of date values doesn't depend on JVM time zone.
   3. While returning dates/timestamps of Java 8 type, we can avoid dates/timestamps rebasing from Proleptic Gregorian calendar to the hybrid calendar (Julian + Gregorian), and the issues related to calendar switching.
   4. Properly handle negative years (BCE).
   5. Consistent conversion of date/timestamp strings to/from internal Catalyst types in both direction to and from Spark.
   
   ### Does this PR introduce any user-facing change?
   Yes. Before:
   ```sql
   spark-sql> select make_date(-44, 3, 15);
   0045-03-15
   ```
   After:
   ```sql
   spark-sql> select make_date(-44, 3, 15);
   -0044-03-15
   ```
   
   
   ### How was this patch tested?
   Manually via `bin/spark-sql`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639123368






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639137856


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639010818


   **[Test build #123540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123540/testReport)** for PR 28729 at commit [`930c293`](https://github.com/apache/spark/commit/930c2935b6b493aa9dcfa26fb85112691283ae62).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] juliuszsompolski commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639441579


   It should "work" as in not crash/throw errors, but revert to the inconsistencies it had before this PR, correct @MaxGekk ? I'd say that it's the user conscious choice if they do that and that's fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639291503


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] juliuszsompolski commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639028923


   Could you add a test that fails before and is fixed after this change to HiveThriftServerBinarySuite (for JDBC) and CLISuite? I think it could be similar to the test for SPARK-31861?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639395773


   > Does it still work if the user sets the java 8 time config to false manually?
   
   It should work because we still have cases for the legacy types in toHiveString, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639293646


   **[Test build #123551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123551/testReport)** for PR 28729 at commit [`3c35cf5`](https://github.com/apache/spark/commit/3c35cf5920c6e4216adcefc866bd518dfe635def).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639314448


   **[Test build #123554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123554/testReport)** for PR 28729 at commit [`d130f23`](https://github.com/apache/spark/commit/d130f230f27262d00b61e9b4cb7dd9caa8edf6d5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639468603






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639007694






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639445771






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639030435






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28729:
URL: https://github.com/apache/spark/pull/28729#discussion_r435462628



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperation.scala
##########
@@ -73,7 +73,7 @@ private[hive] trait SparkOperation extends Operation with Logging {
           sqlContext.sparkContext.setLocalProperty(SparkContext.SPARK_SCHEDULER_POOL, pool)
         case None =>
       }
-
+      sqlContext.sparkContext.setLocalProperty(SQLConf.DATETIME_JAVA8API_ENABLED.key, "true")

Review comment:
       shall we forbid users setting the java 8 time config back?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] juliuszsompolski commented on a change in pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on a change in pull request #28729:
URL: https://github.com/apache/spark/pull/28729#discussion_r435458068



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperation.scala
##########
@@ -73,7 +73,7 @@ private[hive] trait SparkOperation extends Operation with Logging {
           sqlContext.sparkContext.setLocalProperty(SparkContext.SPARK_SCHEDULER_POOL, pool)
         case None =>
       }
-
+      sqlContext.sparkContext.setLocalProperty(SQLConf.DATETIME_JAVA8API_ENABLED.key, "true")

Review comment:
       I think this needs to be set in sqlContext.sparkSession.conf, not as sqlContext.sparkContext.setLocalProperty.
   ...
   actually, an even better place to set it would be here in openSession, to just set it once per session. https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala#L65




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28729:
URL: https://github.com/apache/spark/pull/28729


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639007694






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639311966






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639137856






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639137804


   **[Test build #123544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123544/testReport)** for PR 28729 at commit [`3c35cf5`](https://github.com/apache/spark/commit/3c35cf5920c6e4216adcefc866bd518dfe635def).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639314448


   **[Test build #123554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123554/testReport)** for PR 28729 at commit [`d130f23`](https://github.com/apache/spark/commit/d130f230f27262d00b61e9b4cb7dd9caa8edf6d5).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639293646


   **[Test build #123551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123551/testReport)** for PR 28729 at commit [`3c35cf5`](https://github.com/apache/spark/commit/3c35cf5920c6e4216adcefc866bd518dfe635def).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639294132






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639030435






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639526004


   Late LGTM too


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639010818


   **[Test build #123540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123540/testReport)** for PR 28729 at commit [`930c293`](https://github.com/apache/spark/commit/930c2935b6b493aa9dcfa26fb85112691283ae62).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639468603






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639294132






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639468296


   **[Test build #123563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123563/testReport)** for PR 28729 at commit [`f3e5357`](https://github.com/apache/spark/commit/f3e5357a2ca7b650593442da8ee249b928c2d944).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639311966






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639331601


   **[Test build #123554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123554/testReport)** for PR 28729 at commit [`d130f23`](https://github.com/apache/spark/commit/d130f230f27262d00b61e9b4cb7dd9caa8edf6d5).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639299111






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639449087


   **[Test build #123563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123563/testReport)** for PR 28729 at commit [`f3e5357`](https://github.com/apache/spark/commit/f3e5357a2ca7b650593442da8ee249b928c2d944).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639299121


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123551/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639030151


   **[Test build #123540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123540/testReport)** for PR 28729 at commit [`930c293`](https://github.com/apache/spark/commit/930c2935b6b493aa9dcfa26fb85112691283ae62).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639137871


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/123544/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639445771






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639122853


   **[Test build #123544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123544/testReport)** for PR 28729 at commit [`3c35cf5`](https://github.com/apache/spark/commit/3c35cf5920c6e4216adcefc866bd518dfe635def).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639525168


   thanks, merging to master!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639299111


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639449087


   **[Test build #123563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123563/testReport)** for PR 28729 at commit [`f3e5357`](https://github.com/apache/spark/commit/f3e5357a2ca7b650593442da8ee249b928c2d944).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639122853


   **[Test build #123544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123544/testReport)** for PR 28729 at commit [`3c35cf5`](https://github.com/apache/spark/commit/3c35cf5920c6e4216adcefc866bd518dfe635def).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639393222


   Does it still work if the user sets the java 8 time config to false manually?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639331812






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639123368






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-31910][SQL] Enable Java 8 time API in Thrift server

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28729:
URL: https://github.com/apache/spark/pull/28729#issuecomment-639331812






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org