[GitHub] [hudi] danny0405 commented on a diff in pull request #9013: [HUDI-6437] Refine avg record size by considering both commit and deltacommit

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9013:
URL: https://github.com/apache/hudi/pull/9013#discussion_r1241469975


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/UpsertPartitioner.java:
##########
@@ -170,7 +171,7 @@ private void assignInserts(WorkloadProfile profile, HoodieEngineContext context)
      * may result in OOM by making spark underestimate the actual input record sizes.
      */
     long averageRecordSize = averageBytesPerRecord(table.getMetaClient().getActiveTimeline()
-        .getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION)).filterCompletedInstants(), config);
+        .getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION, DELTA_COMMIT_ACTION)).filterCompletedInstants(), config);

Review Comment:
   We can add a UT for `averageBytesPerRecord` to validate that both commit and delta_commit are included in the algorithm.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org