[GitHub] [maven-resolver] splatch commented on pull request #88: [MRESOLVER-157] Drop ServiceLocator

[GitBox <gi...@apache.org>]

splatch commented on pull request #88:
URL: https://github.com/apache/maven-resolver/pull/88#issuecomment-843966779


   @cstamas @michael-o I gave a try to this PR and there is one thing which I would still warmly welcome in 2.0. This is separation of sisu and guice code from resolver implementation. In such case resolver classes should not be marked as private package but that's another story.
   
   I believe that below packages are DI implementation specific. I don't think they are really required to get resolver working:
   ```
   	com.google.inject;version="[1.4,2)",
   	com.google.inject.binder;version="[1.4,2)",
   	com.google.inject.name;version="[1.4,2)",
   	org.eclipse.sisu,
   ```
   
   These dependencies are coming through `AetherModule`, which I guess might be used somehow elsewhere. They should be marked as optional (for OSGi users) or `AetherModule` should be extracted somewhere else. Is it required to stay in impl since there is already component index for sisu (`META-INF/sisu`)?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org