You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/07/15 18:59:50 UTC
Review Request 71075: Windows: Fixed confusing name for command
executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71075/
-----------------------------------------------------------
Review request for mesos and Greg Mann.
Repository: mesos
Description
-------
This tweaks the generated name for command executors, specifically
for shell commands. The generated name would output `sh -c`, even
on Windows where the shell is `cmd /c`.
Diffs
-----
src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
Diff: https://reviews.apache.org/r/71075/diff/1/
Testing
-------
make
Thanks,
Joseph Wu
Re: Review Request 71075: Windows: Fixed confusing name for command
executors.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71075/#review216634
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On July 15, 2019, 6:59 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71075/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 6:59 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This tweaks the generated name for command executors, specifically
> for shell commands. The generated name would output `sh -c`, even
> on Windows where the shell is `cmd /c`.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/71075/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71075: Windows: Fixed confusing name for command
executors.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71075/#review216631
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71075]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On July 15, 2019, 6:59 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71075/
> -----------------------------------------------------------
>
> (Updated July 15, 2019, 6:59 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This tweaks the generated name for command executors, specifically
> for shell commands. The generated name would output `sh -c`, even
> on Windows where the shell is `cmd /c`.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 30039b0857a4d85b4b96fa95d7f8724d57cdec6e
>
>
> Diff: https://reviews.apache.org/r/71075/diff/1/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Joseph Wu
>
>