You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/04/27 13:53:56 UTC
Review Request 46735: Added support for Authorization information to
HELP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/#review130799
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
3rdparty/libprocess/include/process/help.hpp (line 97)
<https://reviews.apache.org/r/46735/#comment194699>
The blank between functions should be two line.
- haosdent huang
On April 27, 2016, 3:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46735/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 3:17 p.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When adding authorization to endpoint we should also
> document the authorization behavior in the HELP (and
> thereby also in the endpoint documentation).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
> 3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
> 3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
>
> Diff: https://reviews.apache.org/r/46735/diff/
>
>
> Testing
> -------
>
> testing with quota endpoint added (see next review).
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 29, 2016, 2:25 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description (updated)
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 29, 2016, 2:25 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description (updated)
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentaion).
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 29, 2016, 2:24 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
CHANGELOG 0c5987779e5f0e2cb416dfe885f7ba836e3958eb
docs/configuration.md 34271c76d10ad930e6cc586c2b820ce8989a053a
include/mesos/authorizer/acls.proto 9adae8c2a2e1b2ee4b9068ea50fcebb0544f2e5d
include/mesos/authorizer/authorizer.proto 32492a59ad95df3bb673ec42321518f86c11af59
src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41
src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f
src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e
src/examples/long_lived_framework.cpp 1740d7cb747d179d06e75153aa334b29e9cdf3c0
src/master/master.cpp 6d3e0f7c634690a35eec1ce827b705e04c3af87e
src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38
src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999
src/slave/flags.cpp 6fde51fc61cfcad61d4085c208bd2eca2eae8f14
src/slave/http.cpp 9b558862e025c5caa71e05fc5eeba783c0ad6fd5
src/slave/slave.hpp b72438033708de473046d321c493d9fbcd7a9b43
src/tests/authorization_tests.cpp f50ac69c32d0551a63391d97f31559ff4f414011
src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2
src/tests/partition_tests.cpp 3ec51cedcea9c7ed5cf41e9e0087fc044c85d2f1
src/tests/slave_authorization_tests.cpp d3ab0835c8d2464a65f382087d914412dc573b44
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/#review131090
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/include/process/help.hpp (line 47)
<https://reviews.apache.org/r/46735/#comment195035>
I might say "authorization requirements and granularity".
- Neil Conway
On April 27, 2016, 3:33 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46735/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 3:33 p.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When adding authorization to endpoint we should also
> document the authorization behavior in the HELP (and
> thereby also in the endpoint documentation).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
> 3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
> 3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
>
> Diff: https://reviews.apache.org/r/46735/diff/
>
>
> Testing
> -------
>
> testing with quota endpoint added (see next review).
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/#review131064
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 27, 2016, 5:33 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46735/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 5:33 p.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When adding authorization to endpoint we should also
> document the authorization behavior in the HELP (and
> thereby also in the endpoint documentation).
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
> 3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
> 3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
>
> Diff: https://reviews.apache.org/r/46735/diff/
>
>
> Testing
> -------
>
> testing with quota endpoint added (see next review).
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 27, 2016, 3:33 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 27, 2016, 3:17 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description (updated)
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentation).
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad
Re: Review Request 46735: Added support for Authorization information
to HELP.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46735/
-----------------------------------------------------------
(Updated April 27, 2016, 3:16 p.m.)
Review request for mesos, Adam B and Alexander Rojas.
Repository: mesos
Description (updated)
-------
When adding authorization to endpoint we should also
document the authorization behavior in the HELP (and
thereby also in the endpoint documentaion).
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 3f859803f3096d3161fffb6485ce1ce3cb6b04bc
3rdparty/libprocess/src/help.cpp ff946965360dc688e34a8790b4a5cd8e41fd3d3f
3rdparty/libprocess/src/logging.cpp 1cb0f4a1608e15e28d49793d162b62f326cb31df
Diff: https://reviews.apache.org/r/46735/diff/
Testing
-------
testing with quota endpoint added (see next review).
Thanks,
Joerg Schad