You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/18 00:57:56 UTC

[GitHub] [accumulo] ctubbsii commented on pull request #2712: Rename property GENERAL_SIMPLETIMER_THREADPOOL_SIZE

ctubbsii commented on PR #2712:
URL: https://github.com/apache/accumulo/pull/2712#issuecomment-1129458437

   > The method `AccumuloConfiguration.resolve()`
   > 
   > https://github.com/apache/accumulo/blob/e52df66b944e3e15098fa3ff65ff9f05aad6afc2/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java#L99
   > 
   > 
   > calls the method `isPropertySet()`
   > https://github.com/apache/accumulo/blob/e52df66b944e3e15098fa3ff65ff9f05aad6afc2/core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java#L410
   > 
   > 
   > which has _7 overrides_.
   > ![Image showing base implementation](https://user-images.githubusercontent.com/90329875/168861465-60ceb74d-26a4-4f6b-acf9-716f68f80649.png)
   > 
   > Using the `.resolve()` of our argument `conf` throws an `UnsupportedOperationException`.
   > 
   > How should I proceed? Should I simply generalize the catch clause to `Exception`?
   
   I'm not sure what the problem is. It won't be called on the base class... it will call isPropertySet() on one of the implementing classes that implement it. You don't need to catch either NullPointerException or UnsupportedOperationException.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org