You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/10/14 16:44:35 UTC
[GitHub] [tinkerpop] remiphilippe opened a new pull request, #1829: use go-bindata for error/logger resources
remiphilippe opened a new pull request, #1829:
URL: https://github.com/apache/tinkerpop/pull/1829
following the discussion here: https://groups.google.com/g/gremlin-users/c/rSWrioOk58U
the logger and error files are trying to be loaded at runtime from the repo code, but when the binaries are used it can't find the resources files.
So all errors / logger appear as:
`%!(EXTRA string=ws://localhost:50639/gremlin)`
when using go-bindata (https://github.com/go-bindata/go-bindata) the resources files are generated by a `go generate` statement, and loaded with the binary.
The messages now display properly:
`Closing DriverRemoteConnection with url 'ws://localhost:49696/gremlin'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1287362836
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1829?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1829](https://codecov.io/gh/apache/tinkerpop/pull/1829?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bef9ab0) into [master](https://codecov.io/gh/apache/tinkerpop/commit/fec78da4711128e9f643a69492dbaaa7817b1f70?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fec78da) will **decrease** coverage by `5.06%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #1829 +/- ##
============================================
- Coverage 69.17% 64.11% -5.07%
============================================
Files 875 23 -852
Lines 41759 3684 -38075
Branches 5623 0 -5623
============================================
- Hits 28888 2362 -26526
+ Misses 10894 1154 -9740
+ Partials 1977 168 -1809
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1829?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [gremlin-go/driver/error\_codes.go](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvZXJyb3JfY29kZXMuZ28=) | `100.00% <100.00%> (ø)` | |
| [gremlin-go/driver/logger.go](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1nby9kcml2ZXIvbG9nZ2VyLmdv) | `91.66% <100.00%> (ø)` | |
| [.../apache/tinkerpop/gremlin/console/PluggedIn.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvUGx1Z2dlZEluLmdyb292eQ==) | | |
| [...p/gremlin/server/channel/WsAndHttpChannelizer.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9jaGFubmVsL1dzQW5kSHR0cENoYW5uZWxpemVyLmphdmE=) | | |
| [...n/server/handler/WsGremlinCloseRequestDecoder.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL1dzR3JlbWxpbkNsb3NlUmVxdWVzdERlY29kZXIuamF2YQ==) | | |
| [...raversal/step/util/event/ListCallbackRegistry.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL3V0aWwvZXZlbnQvTGlzdENhbGxiYWNrUmVnaXN0cnkuamF2YQ==) | | |
| [...trategy/finalization/ReferenceElementStrategy.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdHJhdGVneS9maW5hbGl6YXRpb24vUmVmZXJlbmNlRWxlbWVudFN0cmF0ZWd5LmphdmE=) | | |
| [...structure/io/graphson/JavaUtilSerializersV3d0.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvaW8vZ3JhcGhzb24vSmF2YVV0aWxTZXJpYWxpemVyc1YzZDAuamF2YQ==) | | |
| [...gremlin/language/grammar/TraversalRootVisitor.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9sYW5ndWFnZS9ncmFtbWFyL1RyYXZlcnNhbFJvb3RWaXNpdG9yLmphdmE=) | | |
| [.../tinkerpop/gremlin/process/traversal/Bindings.java](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9CaW5kaW5ncy5qYXZh) | | |
| ... and [844 more](https://codecov.io/gh/apache/tinkerpop/pull/1829/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1304289973
Closing this PR as I will be merging all changes cherry-picked through this PR: https://github.com/apache/tinkerpop/pull/1851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1304004260
Thanks for the changes and sorry for the delay. I just noticed we should target to 3.5-dev for this change, so I will cherry pick the commits and merge them to 3.5-dev for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy closed pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
xiazcy closed pull request #1829: use embed for error/logger resources
URL: https://github.com/apache/tinkerpop/pull/1829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] remiphilippe commented on pull request #1829: use go-bindata for error/logger resources
Posted by GitBox <gi...@apache.org>.
remiphilippe commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1281221109
working on fixing that, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1829: use go-bindata for error/logger resources
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1281093462
Remi thank you for PR!
Smoke tests failed because missing headers with Apache license in generated files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] remiphilippe commented on pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
remiphilippe commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1287347868
should work now. Moved to `embed` and added the copyright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #1829: use embed for error/logger resources
Posted by GitBox <gi...@apache.org>.
vkagamlyk commented on PR #1829:
URL: https://github.com/apache/tinkerpop/pull/1829#issuecomment-1287381565
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org