[GitHub] [incubator-iceberg] rdblue commented on issue #234: Make BaseTransaction public

[GitBox <gi...@apache.org>]

rdblue commented on issue #234: Make BaseTransaction public
URL: https://github.com/apache/incubator-iceberg/pull/234#issuecomment-505928357
 
 
   @electrum, can you give more context on where you need to use this? This is probably for create and replace operations in catalogs that aren't defined in Iceberg?
   
   I'd prefer to move the static methods that are made public here to a `Transactions` class instead of making `BaseTransaction` public. I don't think there's a need to expose that class, just the factory methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org