You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/03/30 01:17:47 UTC
Review Request 58060: Added a check to default clang-tidy check list.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58060/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Added a check to default clang-tidy check list.
Diffs
-----
support/mesos-tidy.sh a56ae78b5839dfdacd0d8793f1a9dccb097f0393
Diff: https://reviews.apache.org/r/58060/diff/1/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 58060: Added a check to default clang-tidy check
list.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58060/#review170555
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58037, 58038, 58039, 58040, 58041, 58042, 58043, 58044, 58060]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 30, 2017, 1:17 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58060/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 1:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a check to default clang-tidy check list.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh a56ae78b5839dfdacd0d8793f1a9dccb097f0393
>
>
> Diff: https://reviews.apache.org/r/58060/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 58060: Added a check to default clang-tidy check
list.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58060/#review170537
-----------------------------------------------------------
Ship it!
Note that this patch only requires https://reviews.apache.org/r/58038/.
- Benjamin Bannier
On March 30, 2017, 3:17 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58060/
> -----------------------------------------------------------
>
> (Updated March 30, 2017, 3:17 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a check to default clang-tidy check list.
>
>
> Diffs
> -----
>
> support/mesos-tidy.sh a56ae78b5839dfdacd0d8793f1a9dccb097f0393
>
>
> Diff: https://reviews.apache.org/r/58060/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>