You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/18 03:01:27 UTC

[GitHub] [couchdb-nano] sxwei123 opened a new pull request #230: fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

sxwei123 opened a new pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   The feed of `cloudant-follow` can be stopped by calling `stop()` method. It is missing from the `nano.d.ts` file.
   https://www.npmjs.com/package/cloudant-follow#events
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   Changes to typescript definitions only, no code modified.
   
   ## GitHub issue number
   
   <!-- If this is a significant change, please file a separate issue at:
        https://github.com/apache/couchdb-nano/issues
        and include the number here and in commit message(s) using
        syntax like "Fixes #472" or "Fixes apache/couchdb#472".  -->
   NA.
   ## Related Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those pull requests here.  -->
   NA.
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [x] Documentation reflects the changes;
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird commented on pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
glynnbird commented on pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230#issuecomment-696177570


   Thanks for the feedback. This project is updated on a voluntary basis by unpaid volunteers. If you'd like to volunteer your time to the project, then I'm sure the extra pair of hands would be welcome. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
glynnbird merged pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] insidewhy commented on pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
insidewhy commented on pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230#issuecomment-696164380


   @YC This is a very simple fix, can you merge this? It looks like not many commits are happening to this repo anymore, is it possible to add more maintainers?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] insidewhy commented on pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
insidewhy commented on pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230#issuecomment-696164380






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] insidewhy commented on pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
insidewhy commented on pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230#issuecomment-696218000


   @glynnbird sure. BTW https://github.com/apache/couchdb-nano/pull/231 is another simple PR and quick win.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird merged pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
glynnbird merged pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-nano] glynnbird commented on pull request #230: Fix nano.d.ts: Add FollowEmitter.stop() to typescript declaration file

Posted by GitBox <gi...@apache.org>.
glynnbird commented on pull request #230:
URL: https://github.com/apache/couchdb-nano/pull/230#issuecomment-696177570


   Thanks for the feedback. This project is updated on a voluntary basis by unpaid volunteers. If you'd like to volunteer your time to the project, then I'm sure the extra pair of hands would be welcome. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org