You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Kevin Wilfong <ke...@fb.com> on 2011/08/10 02:14:37 UTC
Review Request: Make performance logging configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1443/
-----------------------------------------------------------
Review request for hive and Ning Zhang.
Summary
-------
I created a new class PerfLogger, which wraps the old functionality of Utilities' PerfLogBegin and PerfLogBegin methods. I also added a config variable hive.exec.perf.logger. The value of this variable can be changed to point to a subclass of PerfLogger which can customize the code in PerfLogBegin and PerfLogEnd.
This addresses bug HIVE-2364.
https://issues.apache.org/jira/browse/HIVE-2364
Diffs
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155439
trunk/conf/hive-default.xml 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1155439
Diff: https://reviews.apache.org/r/1443/diff
Testing
-------
I ran the code as it is and made sure it continued to log the performance messages as before.
I also created a subclass of PerfLogger and used its class name as the value of hive.exec.perf.logger, and verified the subclass's code was run.
Thanks,
Kevin
Re: Review Request: Make performance logging configurable.
Posted by Kevin Wilfong <ke...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1443/
-----------------------------------------------------------
(Updated 2011-08-14 00:54:16.595577)
Review request for hive and Ning Zhang.
Changes
-------
Updated patch.
Summary
-------
I created a new class PerfLogger, which wraps the old functionality of Utilities' PerfLogBegin and PerfLogBegin methods. I also added a config variable hive.exec.perf.logger. The value of this variable can be changed to point to a subclass of PerfLogger which can customize the code in PerfLogBegin and PerfLogEnd.
This addresses bug HIVE-2364.
https://issues.apache.org/jira/browse/HIVE-2364
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1157444
trunk/conf/hive-default.xml 1157444
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1157444
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1157444
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1157444
Diff: https://reviews.apache.org/r/1443/diff
Testing
-------
I ran the code as it is and made sure it continued to log the performance messages as before.
I also created a subclass of PerfLogger and used its class name as the value of hive.exec.perf.logger, and verified the subclass's code was run.
Thanks,
Kevin
Re: Review Request: Make performance logging configurable.
Posted by Kevin Wilfong <ke...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1443/
-----------------------------------------------------------
(Updated 2011-08-10 00:18:50.035513)
Review request for hive and Ning Zhang.
Changes
-------
Forgot to add the licensing info to the top of PerfLogger.
Summary
-------
I created a new class PerfLogger, which wraps the old functionality of Utilities' PerfLogBegin and PerfLogBegin methods. I also added a config variable hive.exec.perf.logger. The value of this variable can be changed to point to a subclass of PerfLogger which can customize the code in PerfLogBegin and PerfLogEnd.
This addresses bug HIVE-2364.
https://issues.apache.org/jira/browse/HIVE-2364
Diffs (updated)
-----
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155439
trunk/conf/hive-default.xml 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1155439
trunk/ql/src/java/org/apache/hadoop/hive/ql/log/PerfLogger.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1155439
Diff: https://reviews.apache.org/r/1443/diff
Testing
-------
I ran the code as it is and made sure it continued to log the performance messages as before.
I also created a subclass of PerfLogger and used its class name as the value of hive.exec.perf.logger, and verified the subclass's code was run.
Thanks,
Kevin