You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/31 07:37:56 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #10697: [fix #9640] remove `pulsar-client-admin-api` dependency : `pulsar-common`

codelipenghui commented on a change in pull request #10697:
URL: https://github.com/apache/pulsar/pull/10697#discussion_r642278059



##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Namespaces.java
##########
@@ -3681,7 +3681,7 @@ void setIsAllowAutoUpdateSchema(String namespace, boolean isAllowAutoUpdateSchem
      * @throws PulsarAdminException
      *             Unexpected error
      */
-    void setOffloadPolicies(String namespace, OffloadPolicies offloadPolicies) throws PulsarAdminException;

Review comment:
       This will also be a break change.

##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/BrokerStats.java
##########
@@ -36,15 +34,15 @@
      * @throws PulsarAdminException
      */
 
-    JsonArray getMetrics() throws PulsarAdminException;

Review comment:
       Will be a breaking change if we change the interface




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org