You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2024/03/26 01:35:59 UTC

[PR] sched/signal: add sanity check for siginfo [nuttx]

anchao opened a new pull request, #11997:
URL: https://github.com/apache/nuttx/pull/11997

   
   ## Summary
   
   sched/signal: add sanity check for siginfo
   
   
   add sanity check for siginfo to ensure whether there is really a consumer waiting for the signal, since the task state will not be changed appropriately if in cancel/killed case
   
   Test Case:
   https://github.com/linux-test-project/ltp/blob/master/testcases/open_posix_testsuite/conformance/interfaces/sigpause/1-1.c#L63
   
   More information:
   https://github.com/apache/nuttx/pull/11988
   https://github.com/apache/nuttx/pull/11916
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ltp test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "fxysunshine (via GitHub)" <gi...@apache.org>.
fxysunshine commented on PR #11997:
URL: https://github.com/apache/nuttx/pull/11997#issuecomment-2019853078

   > > @anchao could you cherry-pick [bcce3ed](https://github.com/apache/nuttx/commit/bcce3ed5b46c89fe4ec09869bf0812205c0f541b) into this pr?
   > 
   > @xiaoxiang781216 @fxysunshine I think there should be some patches in your internal server. I reverted this ci PR and please check it internally.
   
   @anchao  It's all passed in my local machine to run the cases the same with CI server. I think the problem is only triggered in the CI server. I will investigate later, and you can revert the ci about adding sigpause case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11997:
URL: https://github.com/apache/nuttx/pull/11997#issuecomment-2019229250

   @anchao could you cherry-pick:
   https://github.com/apache/nuttx/pull/11988/commits/bcce3ed5b46c89fe4ec09869bf0812205c0f541b
   into this pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11997:
URL: https://github.com/apache/nuttx/pull/11997#issuecomment-2019838448

   > @anchao could you cherry-pick [bcce3ed](https://github.com/apache/nuttx/commit/bcce3ed5b46c89fe4ec09869bf0812205c0f541b) into this pr?
   
   @xiaoxiang781216 @fxysunshine
   I think there should be some patches in your internal server. I reverted this ci PR and please check it internally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11997:
URL: https://github.com/apache/nuttx/pull/11997#issuecomment-2019828892

   It seems that some tests still break:
   1. test_ltp_interfaces_pthread_rwlock_timedrdlock_3_1
   
   `FAILED test_open_posix/test_openposix_.py::test_ltp_interfaces_pthread_rwlock_timedrdlock_3_1`
   
   I tried runing this case locally, seems work as expected:
   https://github.com/linux-test-project/ltp/blob/master/testcases/open_posix_testsuite/conformance/interfaces/pthread_rwlock_timedrdlock/3-1.c
   
   ```
   nsh> time hello
   main: attempt read lock
   main: acquired read lock
   main: create rd_thread1
   Test CLOCK_REALTIME
   thread: attempt timed read lock, 3 secs
   thread: acquired read lock
   thread: unlock read lock
   main: unlock read lock
   main: attempt write lock
   main: acquired write lock
   main: create rd_thread2
   Test CLOCK_REALTIME
   thread: attempt timed read lock, 3 secs
   thread: timer expired
   thread: read lock correctly timed out
   main: unlock write lock
   Test PASSED
   
   
   4.0400 sec
   ```
   
   2. Too many cases cause build command line too long, @xiaoxiang781216  maybe we need to update the ltp makefile?
   
   ```
   Configuration/Tool: sim/configdata
   ------------------------------------------------------------------------------------
     Cleaning...
   make[3]: /usr/bin/bash: Argument list too long
   make[3]: *** [/github/workspace/sources/apps/Application.mk:323: clean] Error 127
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11997:
URL: https://github.com/apache/nuttx/pull/11997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] sched/signal: add sanity check for siginfo [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11997:
URL: https://github.com/apache/nuttx/pull/11997#issuecomment-2019236033

   > @anchao could you cherry-pick [bcce3ed](https://github.com/apache/nuttx/commit/bcce3ed5b46c89fe4ec09869bf0812205c0f541b) into this pr?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org