You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/02/06 03:09:09 UTC
[GitHub] [kafka] ijuma opened a new pull request, #13199: MINOR: Update build and test dependencies for 3.5
ijuma opened a new pull request, #13199:
URL: https://github.com/apache/kafka/pull/13199
Gradle plugin updates:
* spotless: 6.10.0 -> 6.14.1
* versions: 0.42.0 -> 0.44.0
* dependencycheck: 7.1.1 -> 8.0.2
* rat: 0.7.1 -> 0.8.0
* spotbugs: 5.0.9 -> 5.0.13
* test-retry: 1.4.0 -> 1.5.1
* scoverage: 7.0.0 -> 7.0.1
Test/benchmark updates:
* easymock: 4.3 -> 5.1.0
* jmh: 1.35 -> 1.36
* junit: 5.9.0 -> 5.9.1
* jqwik: 1.6.5 -> 1.7.2
* mockito: 4.6.1 -> 4.11.0
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] clolov commented on pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on PR #13199:
URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419072645
Do we use some tool which suggests these newer versions or we do the checks manually for each release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13199:
URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419378585
@showuon This is now ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on code in PR #13199:
URL: https://github.com/apache/kafka/pull/13199#discussion_r1096911636
##########
build.gradle:
##########
@@ -30,16 +30,16 @@ buildscript {
}
plugins {
- id 'com.diffplug.spotless' version '6.10.0'
- id 'com.github.ben-manes.versions' version '0.42.0'
+ id 'com.diffplug.spotless' version '6.14.1'
Review Comment:
6.14.1 is available, see here https://search.maven.org/artifact/com.diffplug.spotless/spotless-plugin-gradle/6.14.1/jar
But it requires Java 11 to build, so I had to downgrade to 6.13.0..
I'll ping reviewers once I get a green build. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] stanislavkozlovski merged pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "stanislavkozlovski (via GitHub)" <gi...@apache.org>.
stanislavkozlovski merged PR #13199:
URL: https://github.com/apache/kafka/pull/13199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #13199:
URL: https://github.com/apache/kafka/pull/13199#issuecomment-1419378251
JDK 11 build passed, the other two had unrelated failures:
> Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true 20 sec 1
> Build / JDK 8 and Scala 2.12 / kafka.admin.ReassignPartitionsIntegrationTest.testProduceAndConsumeWithReassignmentInProgress(String).quorum=kraft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #13199: MINOR: Update build and test dependencies for 3.5
Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13199:
URL: https://github.com/apache/kafka/pull/13199#discussion_r1096908853
##########
build.gradle:
##########
@@ -30,16 +30,16 @@ buildscript {
}
plugins {
- id 'com.diffplug.spotless' version '6.10.0'
- id 'com.github.ben-manes.versions' version '0.42.0'
+ id 'com.diffplug.spotless' version '6.14.1'
Review Comment:
The latest version of `spotless-plugin-gradle` in maven is `6.14.0`.
ref: https://mvnrepository.com/artifact/com.diffplug.spotless/spotless-plugin-gradle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org