[GitHub] mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz types

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz types
URL: https://github.com/apache/incubator-superset/pull/5100#discussion_r192300801
 
 

 ##########
 File path: superset/assets/src/explore/components/ExploreViewContainer.jsx
 ##########
 @@ -299,14 +300,32 @@ class ExploreViewContainer extends React.Component {
 ExploreViewContainer.propTypes = propTypes;
 
 function mapStateToProps({ explore, charts, impressionId }) {
-  const form_data = getFormDataFromControls(explore.controls);
+  const rawFormDataControls = getControlsState(explore, explore.rawFormData);
 
 Review comment:
   is this constant used anywhere?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org