You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/18 20:18:53 UTC
[GitHub] [samza] lakshmi-manasa-g opened a new pull request #1363: AzureBlobSystemProducer: Catch all throwable in completableFuture during flush of producer
lakshmi-manasa-g opened a new pull request #1363:
URL: https://github.com/apache/samza/pull/1363
**Bug fix**
**Symptom:** No visible symptoms seen yet. Potential symptom is silent drop of exceptions in producer.flush.
**Cause:** During producer.flush, all writers are closed. The CompletableFuture waiting on the writer.close catches only IOExceptions but the writers could throw any exception. This might result exceptions other than IOException not being bubbled up.
**Changes:** Make CompletableFuture catch all "throwable"
**API changes:** None
**Upgrade Instructions:** None
**Usage Instructions:** None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu merged pull request #1363: AzureBlobSystemProducer: Catch all Exception in completableFuture during flush of producer
Posted by GitBox <gi...@apache.org>.
rmatharu merged pull request #1363:
URL: https://github.com/apache/samza/pull/1363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on pull request #1363: AzureBlobSystemProducer: Catch all Exception in completableFuture during flush of producer
Posted by GitBox <gi...@apache.org>.
rmatharu commented on pull request #1363:
URL: https://github.com/apache/samza/pull/1363#issuecomment-777144486
Looks like there is a conflict? that needs to be resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] prateekm commented on a change in pull request #1363: AzureBlobSystemProducer: Catch all throwable in completableFuture during flush of producer
Posted by GitBox <gi...@apache.org>.
prateekm commented on a change in pull request #1363:
URL: https://github.com/apache/samza/pull/1363#discussion_r426928216
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/producer/AzureBlobSystemProducer.java
##########
@@ -490,7 +490,7 @@ private void closeWriters(String source, Map<String, AzureBlobWriter> sourceWrit
public void run() {
try {
writer.close();
- } catch (IOException e) {
+ } catch (Throwable e) {
Review comment:
Minor: Should catch Exception instead of Throwable. Later includes fatal errors like OOM, stack overflow, classloading errors etc that typically shouldn't be caught.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org