You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/12/10 18:53:13 UTC
[GitHub] [tvm] driazati opened a new pull request #9710: Clarify error message for missing libraries
driazati opened a new pull request #9710:
URL: https://github.com/apache/tvm/pull/9710
Ran into this when importing tvm without a build
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #9710: Clarify error message for missing libraries
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #9710:
URL: https://github.com/apache/tvm/pull/9710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #9710: Clarify error message for missing libraries
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #9710:
URL: https://github.com/apache/tvm/pull/9710#discussion_r768159328
##########
File path: python/tvm/_ffi/libinfo.py
##########
@@ -114,18 +114,18 @@ def find_lib_path(name=None, search_path=None, optional=False):
runtime_dll_path = []
else:
if sys.platform.startswith("win32"):
- lib_dll_path = [os.path.join(p, "libtvm.dll") for p in dll_path] + [
- os.path.join(p, "tvm.dll") for p in dll_path
- ]
- runtime_dll_path = [os.path.join(p, "libtvm_runtime.dll") for p in dll_path] + [
- os.path.join(p, "tvm_runtime.dll") for p in dll_path
- ]
+ lib_dll_names = ["libtvm.dll", "tvm.dll"]
+ runtime_dll_names = ["libtvm_runtime.dll", "tvm_runtime.dll"]
Review comment:
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #9710: Clarify error message for missing libraries
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #9710:
URL: https://github.com/apache/tvm/pull/9710#discussion_r768159328
##########
File path: python/tvm/_ffi/libinfo.py
##########
@@ -114,18 +114,18 @@ def find_lib_path(name=None, search_path=None, optional=False):
runtime_dll_path = []
else:
if sys.platform.startswith("win32"):
- lib_dll_path = [os.path.join(p, "libtvm.dll") for p in dll_path] + [
- os.path.join(p, "tvm.dll") for p in dll_path
- ]
- runtime_dll_path = [os.path.join(p, "libtvm_runtime.dll") for p in dll_path] + [
- os.path.join(p, "tvm_runtime.dll") for p in dll_path
- ]
+ lib_dll_names = ["libtvm.dll", "tvm.dll"]
+ runtime_dll_names = ["libtvm_runtime.dll", "tvm_runtime.dll"]
Review comment:
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org