You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2016/06/03 22:50:59 UTC

[jira] [Commented] (HBASE-15849) Shell Cleanup: Simplify handling of commands' runtime

    [ https://issues.apache.org/jira/browse/HBASE-15849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315039#comment-15315039 ] 

Appy commented on HBASE-15849:
------------------------------

Stack +1ed on review board.
Committed to master.

> Shell Cleanup: Simplify handling of commands' runtime
> -----------------------------------------------------
>
>                 Key: HBASE-15849
>                 URL: https://issues.apache.org/jira/browse/HBASE-15849
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Minor
>         Attachments: HBASE-15849.master.001.patch
>
>
> Functions format_simple_command and format_and_return_simple_command are used to print runtimes right now. They are called from within every single command and use Ruby's 'yield' magic.  Instead, we can simplify it using 'command_safe' function. Since command_safe wraps all commands, we can simply time before and after we call individual command.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)