You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/18 14:16:26 UTC

[GitHub] [spark] cloud-fan opened a new pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

cloud-fan opened a new pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   mention the alternative if users do want to use map type as key.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   it's better to provide an alternative when we ban something.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   no
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   N/A

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588746041
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587492363
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588174238
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118673/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168667
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23425/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#discussion_r381154036
 
 

 ##########
 File path: docs/sql-migration-guide.md
 ##########
 @@ -43,7 +43,7 @@ license: |
 
   - The `ADD JAR` command previously returned a result set with the single value 0. It now returns an empty result set.
 
-  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
+  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions, users can use array<struct<key, value>> as map keys instead. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
 
 Review comment:
   > ... built-in functions, users can use array<struct<key, value>> as map keys instead. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
   
   I would write as below:
   
   ... built-in functions. Users can use `array<struct<key, value>>` as map keys instead as a workaround. In addition, users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168020
 
 
   **[Test build #118673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118673/testReport)** for PR 27621 at commit [`00a601d`](https://github.com/apache/spark/commit/00a601d4968c533cc4f4330f12b83cd3bf8d3853).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#discussion_r381149713
 
 

 ##########
 File path: docs/sql-migration-guide.md
 ##########
 @@ -43,7 +43,7 @@ license: |
 
   - The `ADD JAR` command previously returned a result set with the single value 0. It now returns an empty result set.
 
-  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
+  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions, users can use array<struct<key, value>> as map keys instead. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
 
 Review comment:
   no need to change but wanted to point out: "like" -> "such as"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589006000
 
 
   **[Test build #118706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118706/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168661
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587481312
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589006875
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118706/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] gatorsmile commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#discussion_r381740913
 
 

 ##########
 File path: docs/sql-migration-guide.md
 ##########
 @@ -43,7 +43,7 @@ license: |
 
   - The `ADD JAR` command previously returned a result set with the single value 0. It now returns an empty result set.
 
-  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
+  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function such as `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions. Users can use array<struct<key, value>> as map keys instead as a workaround. In addition, users can still read map values with map type key from data source or Java/Scala collections, though it is discouraged.
 
 Review comment:
   Could we give a very simple example, how to use array<struct<key, value>> as map keys as a workaround? Also, do we have such a test case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588746073
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23457/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589006863
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588746073
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23457/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588743675
 
 
   **[Test build #118706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118706/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588725716
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118697/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588174230
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588725685
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588740815
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609201
 
 
   **[Test build #118697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118697/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587492378
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118641/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609201
 
 
   **[Test build #118697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118697/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587481312
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588174238
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118673/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588725685
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587481109
 
 
   cc @HyukjinKwon @zsxwing 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588174114
 
 
   **[Test build #118673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118673/testReport)** for PR 27621 at commit [`00a601d`](https://github.com/apache/spark/commit/00a601d4968c533cc4f4330f12b83cd3bf8d3853).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609512
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23448/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609509
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588725716
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118697/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588724748
 
 
   **[Test build #118697 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118697/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587481330
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23394/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587492378
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118641/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168661
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587484621
 
 
   **[Test build #118641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118641/testReport)** for PR 27621 at commit [`7840774`](https://github.com/apache/spark/commit/784077423991aa8d02cbd112cca3fe037ceb8d2b).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589062529
 
 
   thanks for review, merging to master/3.0!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588743675
 
 
   **[Test build #118706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118706/testReport)** for PR 27621 at commit [`ec9f494`](https://github.com/apache/spark/commit/ec9f4942f57ac03057e78ac5ce87758a4de45098).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589006863
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587481330
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23394/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#discussion_r381154715
 
 

 ##########
 File path: docs/sql-migration-guide.md
 ##########
 @@ -43,7 +43,7 @@ license: |
 
   - The `ADD JAR` command previously returned a result set with the single value 0. It now returns an empty result set.
 
-  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
+  - In Spark version 2.4 and earlier, users can create map values with map type key via built-in function like `CreateMap`, `MapFromArrays`, etc. Since Spark 3.0, it's not allowed to create map values with map type key with these built-in functions, users can use array<struct<key, value>> as map keys instead. Users can still read map values with map type key from data source or Java/Scala collections, though they are not very useful.
 
 Review comment:
   Maybe .. "though they are not very useful." -> "though it is discouraged." (?).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588174230
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168020
 
 
   **[Test build #118673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118673/testReport)** for PR 27621 at commit [`00a601d`](https://github.com/apache/spark/commit/00a601d4968c533cc4f4330f12b83cd3bf8d3853).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588609512
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23448/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588746041
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587484621
 
 
   **[Test build #118641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118641/testReport)** for PR 27621 at commit [`7840774`](https://github.com/apache/spark/commit/784077423991aa8d02cbd112cca3fe037ceb8d2b).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587492155
 
 
   **[Test build #118641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118641/testReport)** for PR 27621 at commit [`7840774`](https://github.com/apache/spark/commit/784077423991aa8d02cbd112cca3fe037ceb8d2b).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-588168667
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23425/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-589006875
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118706/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27621: [SPARK-26071][followup] Improve migration guide of disallowing map type map key
URL: https://github.com/apache/spark/pull/27621#issuecomment-587492363
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org