You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/29 09:37:07 UTC
[GitHub] [rocketmq] codecov-commenter commented on pull request #4723: [ISSUE #4496] Response should not be processed during the NettyRequestProcessor requestProcess, neither by being assigned as NULL nor by being written to the Netty channel.
codecov-commenter commented on PR #4723:
URL: https://github.com/apache/rocketmq/pull/4723#issuecomment-1199074679
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4723](https://codecov.io/gh/apache/rocketmq/pull/4723?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1d28bb6) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c0e375123a2c9d7138c074353440b5395a3223af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0e3751) will **decrease** coverage by `0.23%`.
> The diff coverage is `32.80%`.
```diff
@@ Coverage Diff @@
## develop #4723 +/- ##
=============================================
- Coverage 44.82% 44.59% -0.24%
+ Complexity 7564 7538 -26
=============================================
Files 977 983 +6
Lines 67640 67744 +104
Branches 8933 8944 +11
=============================================
- Hits 30321 30209 -112
- Misses 33581 33789 +208
- Partials 3738 3746 +8
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cketmq/broker/longpolling/NotificationRequest.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTm90aWZpY2F0aW9uUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...pache/rocketmq/broker/longpolling/PullRequest.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvUHVsbFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...tmq/broker/longpolling/PullRequestHoldService.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvUHVsbFJlcXVlc3RIb2xkU2VydmljZS5qYXZh) | `16.50% <0.00%> (-0.33%)` | :arrow_down: |
| [...ker/processor/DefaultPullMessageResultHandler.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL0RlZmF1bHRQdWxsTWVzc2FnZVJlc3VsdEhhbmRsZXIuamF2YQ==) | `36.89% <0.00%> (+1.75%)` | :arrow_up: |
| [...cketmq/broker/processor/NotificationProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL05vdGlmaWNhdGlvblByb2Nlc3Nvci5qYXZh) | `10.52% <0.00%> (-0.07%)` | :arrow_down: |
| [...ocketmq/broker/processor/PeekMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BlZWtNZXNzYWdlUHJvY2Vzc29yLmphdmE=) | `3.67% <0.00%> (+0.07%)` | :arrow_up: |
| [...ocketmq/broker/processor/PollingInfoProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvbGxpbmdJbmZvUHJvY2Vzc29yLmphdmE=) | `8.16% <0.00%> (-0.18%)` | :arrow_down: |
| [...cketmq/broker/processor/QueryMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1F1ZXJ5TWVzc2FnZVByb2Nlc3Nvci5qYXZh) | `6.25% <0.00%> (+0.53%)` | :arrow_up: |
| [...e/rocketmq/container/BrokerContainerProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udGFpbmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb250YWluZXIvQnJva2VyQ29udGFpbmVyUHJvY2Vzc29yLmphdmE=) | `4.13% <0.00%> (-0.03%)` | :arrow_down: |
| [...namesrv/processor/ClusterTestRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvQ2x1c3RlclRlc3RSZXF1ZXN0UHJvY2Vzc29yLmphdmE=) | `54.28% <ø> (ø)` | |
| ... and [62 more](https://codecov.io/gh/apache/rocketmq/pull/4723/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org