You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/04/07 20:52:34 UTC
[kudu-CR](branch-1.18.x) [rpc] fix result status handling
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22757
Change subject: [rpc] fix result status handling
......................................................................
[rpc] fix result status handling
This patch addresses sloppy result handling of functions/methods that
return Status in the following directories under $KUDU_HOME/src/kudu:
* rpc
* security
* server
* subprocess
* thrift
* transactions
Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Reviewed-on: http://gerrit.cloudera.org:8080/22702
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 1bfdd6ff826d224cf94cd8e60d02e4a32a0d3ddb)
---
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/webserver-test.cc
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/transactions/txn_status_tablet.cc
13 files changed, 64 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/22757/1
--
To view, visit http://gerrit.cloudera.org:8080/22757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Gerrit-Change-Number: 22757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR](branch-1.18.x) [rpc] fix result status handling
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22757 )
Change subject: [rpc] fix result status handling
......................................................................
[rpc] fix result status handling
This patch addresses sloppy result handling of functions/methods that
return Status in the following directories under $KUDU_HOME/src/kudu:
* rpc
* security
* server
* subprocess
* thrift
* transactions
Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Reviewed-on: http://gerrit.cloudera.org:8080/22702
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit 1bfdd6ff826d224cf94cd8e60d02e4a32a0d3ddb)
Reviewed-on: http://gerrit.cloudera.org:8080/22757
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/negotiation-test.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc-test.cc
M src/kudu/rpc/rpc_stub-test.cc
M src/kudu/security/test/mini_kdc-test.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/webserver-test.cc
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/thrift/sasl_client_transport.cc
M src/kudu/transactions/txn_status_tablet.cc
13 files changed, 64 insertions(+), 36 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Gerrit-Change-Number: 22757
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.18.x) [rpc] fix result status handling
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22757 )
Change subject: [rpc] fix result status handling
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/1265/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Gerrit-Change-Number: 22757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Apr 2025 01:52:16 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [rpc] fix result status handling
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22757 )
Change subject: [rpc] fix result status handling
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1265/
--
To view, visit http://gerrit.cloudera.org:8080/22757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Gerrit-Change-Number: 22757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Apr 2025 20:52:43 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.18.x) [rpc] fix result status handling
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22757 )
Change subject: [rpc] fix result status handling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22757
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4b94047d7d4c7d2dd68c80c99b6d979799ea4b
Gerrit-Change-Number: 22757
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 08 Apr 2025 18:33:03 +0000
Gerrit-HasComments: No