Re: DAV unlock problem.

[Peter Lundblad <pe...@famlundblad.se>]

Justin Erenkrantz writes:
 > On 2/15/06, Alexander Kitaev <al...@tmate.org> wrote:
 > > First:
 > >
 > > PROPFIND to get lock-token (lockdiscovery) is always sent on "svn unlock",
 > > independently on whether there is lock token in the working copy or not. As
 > > PROPFIND is sent just before "UNLOCK" I suppose that "token" passed
 > > toshim_svn_ra_dav_ _unlock is always NULL.
 > 
 > No, it's svn_client_unlock that is fetching the locks well before
 > ra_dav's unlock function is executed (see line 501).  I'm not real
 > clear why we *need* to fetch the tokens from the server if we have it
 > already in the WC though.
 > 

That's a bug in the client code whitch was introduced late in the
locking branch.  XFail test committed in r18691.  Working on the fix.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: DAV unlock problem.

[Peter Lundblad <pe...@famlundblad.se>]

Peter Lundblad writes:
 > Justin Erenkrantz writes:
 >  > On 2/15/06, Alexander Kitaev <al...@tmate.org> wrote:
 >  > No, it's svn_client_unlock that is fetching the locks well before
 >  > ra_dav's unlock function is executed (see line 501).  I'm not real
 >  > clear why we *need* to fetch the tokens from the server if we have it
 >  > already in the WC though.
 >  > 
 > 
 > That's a bug in the client code whitch was introduced late in the
 > locking branch.  XFail test committed in r18691.  Working on the fix.
 > 
Fixed in r18694.  Will nominate for backport to 1.3.x tomorrow.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org