You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/24 13:29:01 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1038: Use a consistent way to get the current time

git-hulk commented on code in PR #1038:
URL: https://github.com/apache/incubator-kvrocks/pull/1038#discussion_r1003315028


##########
src/common/util.h:
##########
@@ -68,7 +68,11 @@ std::vector<std::string> TokenizeRedisProtocol(const std::string &value);
 
 void ThreadSetName(const char *name);
 int aeWait(int fd, int mask, uint64_t milliseconds);
-uint64_t GetTimeStampMS();
-uint64_t GetTimeStampUS();
+template <typename Duration = std::chrono::seconds>
+auto GetTimeStamp() -> typename Duration::rep {

Review Comment:
   aha, never mind, just append a new commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org