You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "pvcnt (via GitHub)" <gi...@apache.org> on 2023/12/01 13:24:27 UTC
[PR] SOLR-17094: Close objects contained inside an ObjectCache [solr]
pvcnt opened a new pull request, #2110:
URL: https://github.com/apache/solr/pull/2110
https://issues.apache.org/jira/browse/SOLR-17094
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
As a plugin author, I often need a place where to store an object which should be a singleton, e.g., at CoreContainer-level. To do so, in spite of a better place, I use the ObjectCache as a holder of my singleton. This makes it easy to store and retrieve my singleton, but it is quite complex to clean it up when CoreContainer is shutting down.
# Solution
This PR modifies ObjectCache to automatically close any Closeable object that is stored within it, in order to serve this use case for plugin authors.
# Tests
Added tests for ObjectCache (new and existing features).
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17094: Close objects contained inside an ObjectCache [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #2110:
URL: https://github.com/apache/solr/pull/2110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17094: Close objects contained inside an ObjectCache [solr]
Posted by "pvcnt (via GitHub)" <gi...@apache.org>.
pvcnt commented on PR #2110:
URL: https://github.com/apache/solr/pull/2110#issuecomment-1836184605
I guess there was no use so far for it. But for authoring plugins and share global state, it will help me (and hopefully others) a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org