You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/12/14 08:15:58 UTC
Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41254/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 7:15 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Summary (updated)
-----------------
Enabled master get ALLOCATION_SLACK metrics.
Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124
Repository: mesos
Description
-------
Enable master get ALLOCATION_SLACK metrics.
Diffs
-----
src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8
src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4
src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371
src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7
Diff: https://reviews.apache.org/r/41254/diff/
Testing
-------
$ curl "http://192.168.0.107:5050/metrics/snapshot" 2>/dev/null| jq . | grep alloc_slack
"master/cpus_alloc_slack_revocable_total": 3,
"master/cpus_alloc_slack_revocable_used": 0,
"master/disk_alloc_slack_revocable_total": 0,
"master/disk_alloc_slack_revocable_used": 0,
"master/mem_alloc_slack_revocable_total": 1000,
"master/mem_alloc_slack_revocable_used": 0,
Thanks,
Guangya Liu
Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41254/#review112460
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 41791, 41848, 41246, 41248, 41250, 41254]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 3, 2016, 1:31 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41254/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2016, 1:31 p.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
>
>
> Bugs: MESOS-4124
> https://issues.apache.org/jira/browse/MESOS-4124
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Enable master get ALLOCATION_SLACK metrics.
>
>
> Diffs
> -----
>
> src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9
> src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
> src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371
> src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7
> src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146
>
> Diff: https://reviews.apache.org/r/41254/diff/
>
>
> Testing
> -------
>
> $ curl "http://192.168.0.107:5050/metrics/snapshot" 2>/dev/null| jq . | grep allocation_slack
> "master/cpus_allocation_slack_percent": 0,
> "master/cpus_allocation_slack_total": 3,
> "master/cpus_allocation_slack_used": 0,
> "master/disk_allocation_slack_percent": 0,
> "master/disk_allocation_slack_total": 0,
> "master/disk_allocation_slack_used": 0,
> "master/mem_allocation_slack_percent": 0,
> "master/mem_allocation_slack_total": 1000,
> "master/mem_allocation_slack_used": 0,
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 41254: Enabled master get ALLOCATION_SLACK metrics.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41254/
-----------------------------------------------------------
(Updated 一月 3, 2016, 1:31 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.
Bugs: MESOS-4124
https://issues.apache.org/jira/browse/MESOS-4124
Repository: mesos
Description
-------
Enable master get ALLOCATION_SLACK metrics.
Diffs (updated)
-----
src/master/master.hpp 1cc5531de70bdc0bdce9835c4930dc774406fac9
src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011
src/master/metrics.hpp 551e4eb0f910aa4ce28a2a955019108fcd3d6371
src/master/metrics.cpp 5e4f4d352579dcd391a133600f9d4abc6b2402a7
src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146
Diff: https://reviews.apache.org/r/41254/diff/
Testing (updated)
-------
$ curl "http://192.168.0.107:5050/metrics/snapshot" 2>/dev/null| jq . | grep allocation_slack
"master/cpus_allocation_slack_percent": 0,
"master/cpus_allocation_slack_total": 3,
"master/cpus_allocation_slack_used": 0,
"master/disk_allocation_slack_percent": 0,
"master/disk_allocation_slack_total": 0,
"master/disk_allocation_slack_used": 0,
"master/mem_allocation_slack_percent": 0,
"master/mem_allocation_slack_total": 1000,
"master/mem_allocation_slack_used": 0,
Thanks,
Guangya Liu